Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29169

RunWrapper.buildVariables should reflect downstream env vars

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • pipeline
    • None

      If you set env.PROP = 'value' in a downstream Workflow build, and an upstream build uses the build step to trigger it, you would expect result.buildVariables.PROP == 'value'.

          [JENKINS-29169] RunWrapper.buildVariables should reflect downstream env vars

          Code changed in jenkins
          User: Jesse Glick
          Path:
          CHANGES.md
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/EnvActionImpl.java
          cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly
          support/src/main/java/org/jenkinsci/plugins/workflow/support/actions/EnvironmentAction.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/RunWrapper.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/help-wait.html
          http://jenkins-ci.org/commit/workflow-plugin/9c26b9edbc7e91e610d0dd9ce887d09a5b8c03ef
          Log:
          [FIXED JENKINS-29169] Give access to env.PROP variables set on a downstream build via buildVariables.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/EnvActionImpl.java cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly support/src/main/java/org/jenkinsci/plugins/workflow/support/actions/EnvironmentAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/RunWrapper.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/help-wait.html http://jenkins-ci.org/commit/workflow-plugin/9c26b9edbc7e91e610d0dd9ce887d09a5b8c03ef Log: [FIXED JENKINS-29169] Give access to env.PROP variables set on a downstream build via buildVariables.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          CHANGES.md
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/EnvActionImpl.java
          cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly
          support/src/main/java/org/jenkinsci/plugins/workflow/support/actions/EnvironmentAction.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/RunWrapper.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/help-wait.html
          http://jenkins-ci.org/commit/workflow-plugin/459318b00a758f5903981816717e56b5d96d624d
          Log:
          JENKINS-29169 Merging #191.

          Conflicts:
          CHANGES.md

          Compare: https://github.com/jenkinsci/workflow-plugin/compare/7080d9759cb5...459318b00a75

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/EnvActionImpl.java cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly support/src/main/java/org/jenkinsci/plugins/workflow/support/actions/EnvironmentAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/RunWrapper.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/help-wait.html http://jenkins-ci.org/commit/workflow-plugin/459318b00a758f5903981816717e56b5d96d624d Log: JENKINS-29169 Merging #191. Conflicts: CHANGES.md Compare: https://github.com/jenkinsci/workflow-plugin/compare/7080d9759cb5...459318b00a75

          Code changed in jenkins
          User: Jesse Glick
          Path:
          support/src/main/java/org/jenkinsci/plugins/workflow/support/actions/EnvironmentAction.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/RunWrapper.java
          http://jenkins-ci.org/commit/workflow-support-plugin/4903979ed7d671cb7a66c57fda6d007537fefa60
          Log:
          [FIXED JENKINS-29169] Give access to env.PROP variables set on a downstream build via buildVariables.
          Originally-Committed-As: 9c26b9edbc7e91e610d0dd9ce887d09a5b8c03ef

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: support/src/main/java/org/jenkinsci/plugins/workflow/support/actions/EnvironmentAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/RunWrapper.java http://jenkins-ci.org/commit/workflow-support-plugin/4903979ed7d671cb7a66c57fda6d007537fefa60 Log: [FIXED JENKINS-29169] Give access to env.PROP variables set on a downstream build via buildVariables. Originally-Committed-As: 9c26b9edbc7e91e610d0dd9ce887d09a5b8c03ef

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/help-wait.html
          http://jenkins-ci.org/commit/pipeline-build-step-plugin/a76ce604ed139701353a08fa7bec89bd1c1f693c
          Log:
          [FIXED JENKINS-29169] Give access to env.PROP variables set on a downstream build via buildVariables.
          Originally-Committed-As: 9c26b9edbc7e91e610d0dd9ce887d09a5b8c03ef

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/help-wait.html http://jenkins-ci.org/commit/pipeline-build-step-plugin/a76ce604ed139701353a08fa7bec89bd1c1f693c Log: [FIXED JENKINS-29169] Give access to env.PROP variables set on a downstream build via buildVariables. Originally-Committed-As: 9c26b9edbc7e91e610d0dd9ce887d09a5b8c03ef

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/help-wait.html
          http://jenkins-ci.org/commit/pipeline-build-step-plugin/57e5949b53d62e678732807ccd838ebe6d443be4
          Log:
          JENKINS-29169 Merging #191.

          Conflicts:
          CHANGES.md

          Originally-Committed-As: 459318b00a758f5903981816717e56b5d96d624d

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/help-wait.html http://jenkins-ci.org/commit/pipeline-build-step-plugin/57e5949b53d62e678732807ccd838ebe6d443be4 Log: JENKINS-29169 Merging #191. Conflicts: CHANGES.md Originally-Committed-As: 459318b00a758f5903981816717e56b5d96d624d

          Code changed in jenkins
          User: Jesse Glick
          Path:
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/EnvActionImpl.java
          cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly
          http://jenkins-ci.org/commit/workflow-cps-plugin/27b89c83019ace9c290a4594b9672042ebe6cff7
          Log:
          [FIXED JENKINS-29169] Give access to env.PROP variables set on a downstream build via buildVariables.
          Originally-Committed-As: 9c26b9edbc7e91e610d0dd9ce887d09a5b8c03ef

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/EnvActionImpl.java cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly http://jenkins-ci.org/commit/workflow-cps-plugin/27b89c83019ace9c290a4594b9672042ebe6cff7 Log: [FIXED JENKINS-29169] Give access to env.PROP variables set on a downstream build via buildVariables. Originally-Committed-As: 9c26b9edbc7e91e610d0dd9ce887d09a5b8c03ef

          Code changed in jenkins
          User: Jesse Glick
          Path:
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/EnvActionImpl.java
          cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly
          http://jenkins-ci.org/commit/workflow-cps-plugin/a46cf8470ab11d4919e5846df2b1006e9bc4dc61
          Log:
          JENKINS-29169 Merging #191.

          Conflicts:
          CHANGES.md

          Originally-Committed-As: 459318b00a758f5903981816717e56b5d96d624d

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/EnvActionImpl.java cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/EnvActionImpl/Binder/help.jelly http://jenkins-ci.org/commit/workflow-cps-plugin/a46cf8470ab11d4919e5846df2b1006e9bc4dc61 Log: JENKINS-29169 Merging #191. Conflicts: CHANGES.md Originally-Committed-As: 459318b00a758f5903981816717e56b5d96d624d

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: