• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • Chrome browser
      Jenkins 1.618

      When viewing Manage Jenkins > Manage Nodes, if I sort on 'Free disk space' the sort is not numeric.

      For example, for ascending sort, I see:

      22.9 GB
      2.8 GB
      176 GB
      174 GB

          [JENKINS-29286] Sort by 'Free Disk Space' is incorrect

          Daniel Beck added a comment -

          Daniel Beck added a comment - Caused by https://github.com/jenkinsci/jenkins/commit/e382bbae1b0deefdce458eed72ce025eb91d1855

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
          core/src/main/resources/hudson/node_monitors/DiskSpaceMonitor/column.jelly
          core/src/main/resources/hudson/node_monitors/SwapSpaceMonitor/column.jelly
          core/src/main/resources/hudson/node_monitors/TemporarySpaceMonitor/column.jelly
          http://jenkins-ci.org/commit/jenkins/fabec0eef00212109a1ad5c2bedcb8c55de4f38a
          Log:
          [FIXED JENKINS-29286] Use byte size to sort disk space monitor columns

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java core/src/main/resources/hudson/node_monitors/DiskSpaceMonitor/column.jelly core/src/main/resources/hudson/node_monitors/SwapSpaceMonitor/column.jelly core/src/main/resources/hudson/node_monitors/TemporarySpaceMonitor/column.jelly http://jenkins-ci.org/commit/jenkins/fabec0eef00212109a1ad5c2bedcb8c55de4f38a Log: [FIXED JENKINS-29286] Use byte size to sort disk space monitor columns

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
          core/src/main/resources/hudson/node_monitors/DiskSpaceMonitor/column.jelly
          core/src/main/resources/hudson/node_monitors/SwapSpaceMonitor/column.jelly
          core/src/main/resources/hudson/node_monitors/TemporarySpaceMonitor/column.jelly
          http://jenkins-ci.org/commit/jenkins/9a853b9d1076c648f6094c818e3c78e9211a9b70
          Log:
          Merge pull request #1763 from olivergondza/JENKINS-29286

          [FIXED JENKINS-29286] Use byte size to sort disk space monitor columns

          Compare: https://github.com/jenkinsci/jenkins/compare/316b32e07b34...9a853b9d1076

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java core/src/main/resources/hudson/node_monitors/DiskSpaceMonitor/column.jelly core/src/main/resources/hudson/node_monitors/SwapSpaceMonitor/column.jelly core/src/main/resources/hudson/node_monitors/TemporarySpaceMonitor/column.jelly http://jenkins-ci.org/commit/jenkins/9a853b9d1076c648f6094c818e3c78e9211a9b70 Log: Merge pull request #1763 from olivergondza/ JENKINS-29286 [FIXED JENKINS-29286] Use byte size to sort disk space monitor columns Compare: https://github.com/jenkinsci/jenkins/compare/316b32e07b34...9a853b9d1076

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
          core/src/main/resources/hudson/node_monitors/DiskSpaceMonitor/column.jelly
          core/src/main/resources/hudson/node_monitors/SwapSpaceMonitor/column.jelly
          core/src/main/resources/hudson/node_monitors/TemporarySpaceMonitor/column.jelly
          http://jenkins-ci.org/commit/jenkins/132b915615bed822a14d751667c4a0842ed6ffa6
          Log:
          [FIXED JENKINS-29286] Use byte size to sort disk space monitor columns

          (cherry picked from commit fabec0eef00212109a1ad5c2bedcb8c55de4f38a)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java core/src/main/resources/hudson/node_monitors/DiskSpaceMonitor/column.jelly core/src/main/resources/hudson/node_monitors/SwapSpaceMonitor/column.jelly core/src/main/resources/hudson/node_monitors/TemporarySpaceMonitor/column.jelly http://jenkins-ci.org/commit/jenkins/132b915615bed822a14d751667c4a0842ed6ffa6 Log: [FIXED JENKINS-29286] Use byte size to sort disk space monitor columns (cherry picked from commit fabec0eef00212109a1ad5c2bedcb8c55de4f38a)

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          [FIXED JENKINS-29286] Use byte size to sort disk space monitor columns (Revision 132b915615bed822a14d751667c4a0842ed6ffa6)

          Result = UNSTABLE
          ogondza : 132b915615bed822a14d751667c4a0842ed6ffa6
          Files :

          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitor/column.jelly
          • core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
          • core/src/main/resources/hudson/node_monitors/TemporarySpaceMonitor/column.jelly
          • core/src/main/resources/hudson/node_monitors/SwapSpaceMonitor/column.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #4292 [FIXED JENKINS-29286] Use byte size to sort disk space monitor columns (Revision 132b915615bed822a14d751667c4a0842ed6ffa6) Result = UNSTABLE ogondza : 132b915615bed822a14d751667c4a0842ed6ffa6 Files : core/src/main/resources/hudson/node_monitors/DiskSpaceMonitor/column.jelly core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java core/src/main/resources/hudson/node_monitors/TemporarySpaceMonitor/column.jelly core/src/main/resources/hudson/node_monitors/SwapSpaceMonitor/column.jelly

            olivergondza Oliver Gondža
            davida2009 David Aldrich
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: