-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
Jenkins 1.609.1
git-client-plugin 1.17.1
git-plugin 2.3.5
A specific custom refspec throws an error. These seem to work:
+refs/heads/master:refs/remotes/origin/master +refs/heads/*:refs/remotes/origin/*
But this does not:
+refs/heads/dev*:refs/remotes/origin/dev*
Here is the stack trace:
javax.servlet.ServletException: java.lang.RuntimeException: Failed to instantiate class org.jenkinsci.plugins.multiplescms.MultiSCM from {"value":"4","scmList":[{"userRemoteConfigs":{"url":"http://gitlab.ops.cld/util/wms-poms.git","credentialsId":"4f6a1f34-faeb-40f9-b8ca-9c2b9dac56a1","name":"","refspec":"+refs/heads/*:refs/remotes/origin/*"},"branches":{"name":"*/dev*"},"":"auto","extensions":{"relativeTargetDir":"wms","stapler-class":"hudson.plugins.git.extensions.impl.RelativeTargetDirectory","$class":"hudson.plugins.git.extensions.impl.RelativeTargetDirectory"},"stapler-class":"hudson.plugins.git.GitSCM","$class":"hudson.plugins.git.GitSCM"},{"userRemoteConfigs":{"url":"http://gitlab.ops.cld/solutions/wcs-project.git","credentialsId":"4f6a1f34-faeb-40f9-b8ca-9c2b9dac56a1","name":"","refspec":"+refs/heads/dev*:refs/remotes/origin/dev*"},"branches":{"name":"*/master"},"":"auto","extensions":{"relativeTargetDir":"wcs-project","stapler-class":"hudson.plugins.git.extensions.impl.RelativeTargetDirectory","$class":"hudson.plugins.git.extensions.impl.RelativeTargetDirectory"},"stapler-class":"hudson.plugins.git.GitSCM","$class":"hudson.plugins.git.GitSCM"}]} at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:796) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876) at org.kohsuke.stapler.MetaClass$6.doDispatch(MetaClass.java:249) at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876) at org.kohsuke.stapler.MetaClass$6.doDispatch(MetaClass.java:249) at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649) at org.kohsuke.stapler.Stapler.service(Stapler.java:238) at javax.servlet.http.HttpServlet.service(HttpServlet.java:848) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:686) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1494) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:123) at hudson.plugins.greenballs.GreenBallFilter.doFilter(GreenBallFilter.java:58) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:120) at net.bull.javamelody.MonitoringFilter.doFilter(MonitoringFilter.java:198) at net.bull.javamelody.MonitoringFilter.doFilter(MonitoringFilter.java:176) at net.bull.javamelody.PluginMonitoringFilter.doFilter(PluginMonitoringFilter.java:85) at org.jvnet.hudson.plugins.monitoring.HudsonMonitoringFilter.doFilter(HudsonMonitoringFilter.java:99) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:120) at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:114) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482) at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:48) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84) at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:117) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249) at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76) at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:168) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482) at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482) at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:81) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482) at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1474) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137) at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:533) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:428) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116) at org.eclipse.jetty.server.Server.handle(Server.java:370) at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489) at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:960) at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1021) at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:865) at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240) at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82) at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:668) at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:52) at winstone.BoundedExecutorService$1.run(BoundedExecutorService.java:77) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.RuntimeException: Failed to instantiate class org.jenkinsci.plugins.multiplescms.MultiSCM from {"value":"4","scmList":[{"userRemoteConfigs":{"url":"http://gitlab.ops.cld/util/wms-poms.git","credentialsId":"4f6a1f34-faeb-40f9-b8ca-9c2b9dac56a1","name":"","refspec":"+refs/heads/*:refs/remotes/origin/*"},"branches":{"name":"*/dev*"},"":"auto","extensions":{"relativeTargetDir":"wms","stapler-class":"hudson.plugins.git.extensions.impl.RelativeTargetDirectory","$class":"hudson.plugins.git.extensions.impl.RelativeTargetDirectory"},"stapler-class":"hudson.plugins.git.GitSCM","$class":"hudson.plugins.git.GitSCM"},{"userRemoteConfigs":{"url":"http://gitlab.ops.cld/solutions/wcs-project.git","credentialsId":"4f6a1f34-faeb-40f9-b8ca-9c2b9dac56a1","name":"","refspec":"+refs/heads/dev*:refs/remotes/origin/dev*"},"branches":{"name":"*/master"},"":"auto","extensions":{"relativeTargetDir":"wcs-project","stapler-class":"hudson.plugins.git.extensions.impl.RelativeTargetDirectory","$class":"hudson.plugins.git.extensions.impl.RelativeTargetDirectory"},"stapler-class":"hudson.plugins.git.GitSCM","$class":"hudson.plugins.git.GitSCM"}]} at hudson.model.Descriptor.newInstance(Descriptor.java:579) at org.jenkinsci.plugins.multiplescms.MultiSCM$DescriptorImpl.newInstance(MultiSCM.java:206) at org.jenkinsci.plugins.multiplescms.MultiSCM$DescriptorImpl.newInstance(MultiSCM.java:168) at hudson.scm.SCMS.parseSCM(SCMS.java:63) at hudson.model.AbstractProject.submit(AbstractProject.java:1862) at hudson.maven.MavenModuleSet.submit(MavenModuleSet.java:1191) at hudson.model.Job.doConfigSubmit(Job.java:1203) at hudson.model.AbstractProject.doConfigSubmit(AbstractProject.java:785) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:298) at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:161) at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:96) at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:121) at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746) ... 74 more Caused by: hudson.plugins.git.GitException: Error creating repositories at hudson.plugins.git.GitSCM$DescriptorImpl.createRepositoryConfigurations(GitSCM.java:1355) at hudson.plugins.git.GitSCM.updateFromUserData(GitSCM.java:224) at hudson.plugins.git.GitSCM.<init>(GitSCM.java:174) at sun.reflect.GeneratedConstructorAccessor203.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:526) at org.kohsuke.stapler.RequestImpl.invokeConstructor(RequestImpl.java:451) at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:703) at org.kohsuke.stapler.RequestImpl.access$200(RequestImpl.java:81) at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:600) at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:647) at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:404) at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:697) at org.kohsuke.stapler.RequestImpl.access$200(RequestImpl.java:81) at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:600) at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:404) at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:400) at hudson.model.Descriptor.newInstance(Descriptor.java:570) ... 91 more Caused by: java.lang.IllegalArgumentException: Invalid refspec refs/heads/dev* at org.eclipse.jgit.transport.RefSpec.checkValid(RefSpec.java:446) at org.eclipse.jgit.transport.RefSpec.<init>(RefSpec.java:148) at org.eclipse.jgit.transport.RemoteConfig.<init>(RemoteConfig.java:186) at org.eclipse.jgit.transport.RemoteConfig.getAllRemoteConfigs(RemoteConfig.java:124) at hudson.plugins.git.GitSCM$DescriptorImpl.createRepositoryConfigurations(GitSCM.java:1353) ... 108 more
I think the code would be much improved if it presented a message in the UI when an invalid refspec is entered, rather than refusing to save the job definition and showing a stack trace.
The git online manual on RefSpec says that the format
is invalid. I believe the code is correct to declare that is an illegal argument (though it really should inform the user of that problem with a much more friendly message than a stack trace and refusal to save the form).
The manual says: