Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29357

Fix findbugs issue in build-timeout-plugin

    XMLWordPrintable

Details

    Description

      Findbugs are introduced in https://github.com/jenkinsci/build-timeout-plugin/pull/41.
      It reveals possible problems in DeadlineTimeStrategy (JENKINS-29163).
      I'll fix that.

      Attachments

        Activity

          Code changed in jenkins
          User: ikedam
          Path:
          pom.xml
          http://jenkins-ci.org/commit/build-timeout-plugin/a70b00894b8b57867bf439c2922361e661c216c0
          Log:
          JENKINS-29357 Specifies source encodings explicitly to have findbugs not fail on non-english locale.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: pom.xml http://jenkins-ci.org/commit/build-timeout-plugin/a70b00894b8b57867bf439c2922361e661c216c0 Log: JENKINS-29357 Specifies source encodings explicitly to have findbugs not fail on non-english locale.

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategy.java
          src/test/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategyTest.java
          http://jenkins-ci.org/commit/build-timeout-plugin/7d5a730be225aed670441ee80d22c0f84e9bd818
          Log:
          [FIXED JENKINS-29357] Fixed findbugs warnings in DeadlineTimeOutStrategy. Mainly the issue about thread-safeness of SimpleDateFormatter.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategy.java src/test/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategyTest.java http://jenkins-ci.org/commit/build-timeout-plugin/7d5a730be225aed670441ee80d22c0f84e9bd818 Log: [FIXED JENKINS-29357] Fixed findbugs warnings in DeadlineTimeOutStrategy. Mainly the issue about thread-safeness of SimpleDateFormatter.

          Code changed in jenkins
          User: ikedam
          Path:
          pom.xml
          src/main/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategy.java
          src/test/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategyTest.java
          http://jenkins-ci.org/commit/build-timeout-plugin/c3156ed8d385f65c8ad585d3139577320920b523
          Log:
          Merge pull request #42 from ikedam/feature/JENKINS-29357_FixFindBugsWarnings

          JENKINS-29357 Fixed findbugs warnings in DeadlineTimeoutStrategy

          Compare: https://github.com/jenkinsci/build-timeout-plugin/compare/86b154b96544...c3156ed8d385

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: pom.xml src/main/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategy.java src/test/java/hudson/plugins/build_timeout/impl/DeadlineTimeOutStrategyTest.java http://jenkins-ci.org/commit/build-timeout-plugin/c3156ed8d385f65c8ad585d3139577320920b523 Log: Merge pull request #42 from ikedam/feature/ JENKINS-29357 _FixFindBugsWarnings JENKINS-29357 Fixed findbugs warnings in DeadlineTimeoutStrategy Compare: https://github.com/jenkinsci/build-timeout-plugin/compare/86b154b96544...c3156ed8d385

          People

            ikedam ikedam
            ikedam ikedam
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: