• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core, git-plugin

      I'm running Jenkins in Tomcat container. On startup, i see the following message in catalina.out:
      ...
      ...
      Jul 12, 2015 4:55:14 PM org.springframework.beans.factory.support.DefaultListableBeanFactory preInstantiateSingletons
      INFO: Pre-instantiating singletons in org.springframework.beans.factory.support.DefaultListableBeanFactory@558f7e2a: defining beans [filter,legacy]; root of factory hierarchy
      Jul 12, 2015 4:55:19 PM hudson.WebAppMain$3 run
      INFO: Jenkins is fully up and running
      Jul 12, 2015 4:56:00 PM hudson.plugins.git.GitTool$DescriptorImpl getInstallation
      WARNING: invalid gitTool selection Default
      ...
      ...
      Jul 12, 2015 4:58:00 PM hudson.plugins.git.GitTool$DescriptorImpl getInstallation
      WARNING: invalid gitTool selection Default
      Jul 12, 2015 4:58:07 PM hudson.model.Run execute
      INFO: GitPermissionCleaner #156254 main build action completed: SUCCESS
      Jul 12, 2015 5:00:00 PM hudson.plugins.git.GitTool$DescriptorImpl getInstallation
      WARNING: invalid gitTool selection Default
      ...
      ...

          [JENKINS-29368] WARNING: invalid gitTool selection Default

          Mark Waite added a comment -

          While the message is surprising, this is a message the plugin has reported for a very long time.

          Mark Waite added a comment - While the message is surprising, this is a message the plugin has reported for a very long time.

          markewaite While it's true this isn't a new error, it seems more likely this is a defect that's simply been ignored. I see it recur on a regular basis in my logs, I suspect either at the point that I edit a job config, or else prepare to run a job.

          Aug 06, 2015 2:05:51 AM WARNING hudson.plugins.git.GitTool$DescriptorImpl getInstallation
          invalid gitTool selection Default

          Jonathan Langevin added a comment - markewaite While it's true this isn't a new error, it seems more likely this is a defect that's simply been ignored. I see it recur on a regular basis in my logs, I suspect either at the point that I edit a job config, or else prepare to run a job. Aug 06, 2015 2:05:51 AM WARNING hudson.plugins.git.GitTool$DescriptorImpl getInstallation invalid gitTool selection Default

          Mark Waite added a comment -

          Since it is a harmless log file warning, I thought it was better not to waste development time removing it. However, since Gaurav Chhabra took the time to report it and intel352 took the time to reopen it, I've prepared a change which will remove the warning.

          Assuming that change passes tests in my multi-platform test setup, it will be included in the next release of the git client plugin after 1.18.0.

          I'd rather not spend further time disputing whether or not a harmless diagnostic warning message is a defect.

          Mark Waite added a comment - Since it is a harmless log file warning, I thought it was better not to waste development time removing it. However, since Gaurav Chhabra took the time to report it and intel352 took the time to reopen it, I've prepared a change which will remove the warning . Assuming that change passes tests in my multi-platform test setup, it will be included in the next release of the git client plugin after 1.18.0. I'd rather not spend further time disputing whether or not a harmless diagnostic warning message is a defect.

          Code changed in jenkins
          User: Mark Waite
          Path:
          src/main/java/hudson/plugins/git/GitTool.java
          http://jenkins-ci.org/commit/git-client-plugin/8dd9a1f97bb30220d3f5ca78785bb2d53353f9e1
          Log:
          [Fix JENKINS-29368] Remove distracting warning about invalid gitTool

          Warning removal simplifies log file, code behavior unchanged

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: src/main/java/hudson/plugins/git/GitTool.java http://jenkins-ci.org/commit/git-client-plugin/8dd9a1f97bb30220d3f5ca78785bb2d53353f9e1 Log: [Fix JENKINS-29368] Remove distracting warning about invalid gitTool Warning removal simplifies log file, code behavior unchanged

          Mark Waite added a comment -

          Included in git client plugin 1.19.0

          Mark Waite added a comment - Included in git client plugin 1.19.0

            laazteca Isabelle Jarrott
            gc Garbageyard
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: