Somewhat related: JENKINS-25242. Same issue with "@" in the path.

A workaround is mentioned in JENKINS-14354, referenced from JENKINS-25242, is to change a system property to use a different specifier for the extra workspaces: -Dhudson.slaves.WorkspaceList=_.

The current discussion in JENKINS-25242 indicates that this problem is also the reason for that issue, so when that is resolved, this issue will either be resolved or turn out to be a workflow-plugin issue (if it doesn't honour that system property for some reason).

Code changed in jenkins
User: Paul Allen
Path:
src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java
http://jenkins-ci.org/commit/p4-plugin/f6727b45c5534741ed6f928b6dd583ef92a2f27f
Log:
Create a template workspace for parallel builds.

If Jenkins attempts a parallel build it creates a workspace@2
directory. This change creates a new template workspace (appended with
.clone2) and substitutes the `@` to `%40` in the root path.

JENKINS-29387

Fixed 1.3.1

p4paul sorry to bump a very old issue, but how can I use your fix when I'm using raw p4groovy to do more advanced stuff?

I have a function called get_synced_changelist() that does exactly what the name implies. This code works fine except if the job runs on an executor other than 0. If that happens, Jenkins appends '@2'  to the workspace and p4groovy crashes when it tries to use that as the workspace root.

Unless I'm missing something, I don't see any way to specify the client's root at the time of instantiation, so I don't know how to avoid this bug.

Here's the code. The best way to repro this is to pin your job to a certain node, then Build it rapidly a few times (ensuring concurrent builds). Any build NOT on the first executor will fail.

 
def get_synced_changelist(String p4_credential_name, String client_name, String p4_stream) {
    def ws = [$class: 'StreamWorkspaceImpl', charset: 'none', format: client_name, pinHost: false, streamName: p4_stream]
    def p4 = p4(credential: p4_credential_name, workspace: ws)
    changelist = p4.run( 'changes', '-m1', "@"+ p4.getClientName() )    
    return changelist[0].change
}
 
get_synced_changelist('p4tools', 'jenkins-${NODE_NAME}${JOB_NAME}${EXECUTOR_NUMBER}', '//depot/stream_name')
 
 
 
 

jayspang you wrote "Jenkins appends '@2'  to the workspace"

Does the above -Dhudson.slaves.WorkspaceList=_ help out as an alternative char to the "@"?  That should obviate the need for the escaping Paul did.

joel_brown I'm a bit reluctant to change a whole system property to fix this issue, but if p4paul says there's no easy way to do this with p4groovy, I'll definitely give that a try!

If you want to list changes limited by the 'view' of a client workspace use 'client syntax' e.g:

changelist = p4.run( 'changes', '-m1', "//" + p4.getClientName() + "/..." )

If you use the "//...@workspace" revision specifier then you are only listing the changes that are in the 'have' list for that workspaces.  If the workspace has never been synced then the have list will be empty and your script will have an empty array:
java.lang.ArrayIndexOutOfBoundsException: 0