Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29533

Does not implement checkRoles(RoleChecker checker) from remoting-2.47

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • s3-plugin
    • None

      The current S3 plugin cannot compile against the current remoting plugin, due to API changes from https://github.com/jenkinsci/remoting/commit/944fb8a801f8d39efbbe21b46401859a7f2d76c3

          [JENKINS-29533] Does not implement checkRoles(RoleChecker checker) from remoting-2.47

          Daniel Beck added a comment -

          In most cases, should suffice to just extend MasterToSlaveCallable or SlaveToMasterCallable as needed.

          Daniel Beck added a comment - In most cases, should suffice to just extend MasterToSlaveCallable or SlaveToMasterCallable as needed.

          Alexander A added a comment -

          Should be ok now.

          Alexander A added a comment - Should be ok now.

          Daniel Beck added a comment -

          jimilian You ignored the Javadoc and introduced a potential security vulnerability.

          https://github.com/jenkinsci/remoting/blob/7cb41387b0210ec96dd48f7cbb75b8238626dcb9/src/main/java/org/jenkinsci/remoting/RoleSensitive.java#L23

          Daniel Beck added a comment - jimilian You ignored the Javadoc and introduced a potential security vulnerability. https://github.com/jenkinsci/remoting/blob/7cb41387b0210ec96dd48f7cbb75b8238626dcb9/src/main/java/org/jenkinsci/remoting/RoleSensitive.java#L23

          Alexander A added a comment - - edited

          Any suggestion?This call can be executed on slave and on master. I found that MasterToSlaveCallable and SlaveToMasterCallable just check role type (MASTER or SLAVE). So, I decided to skip this check, because code could be executed on master as well (plugin has option to submit from master).

          Alexander A added a comment - - edited Any suggestion?This call can be executed on slave and on master. I found that MasterToSlaveCallable and SlaveToMasterCallable just check role type (MASTER or SLAVE). So, I decided to skip this check, because code could be executed on master as well (plugin has option to submit from master).

          Daniel Beck added a comment -

          Not sure. I would assume that's a case for MasterToSlaveCallable, but the doc indicates this would not work.. May need to ask jglick how to best handle this situation.

          References:
          https://github.com/jenkinsci/s3-plugin/blob/ef6bc7a2ca76b4432ce0ffd71a3822dd8f59167a/src/main/java/hudson/plugins/s3/callable/S3Callable.java
          https://github.com/jenkinsci/s3-plugin/tree/ef6bc7a2ca76b4432ce0ffd71a3822dd8f59167a/src/main/java/hudson/plugins/s3/callable/

          Daniel Beck added a comment - Not sure. I would assume that's a case for MasterToSlaveCallable , but the doc indicates this would not work.. May need to ask jglick how to best handle this situation. References: https://github.com/jenkinsci/s3-plugin/blob/ef6bc7a2ca76b4432ce0ffd71a3822dd8f59167a/src/main/java/hudson/plugins/s3/callable/S3Callable.java https://github.com/jenkinsci/s3-plugin/tree/ef6bc7a2ca76b4432ce0ffd71a3822dd8f59167a/src/main/java/hudson/plugins/s3/callable/

            jimilian Alexander A
            directhex Jo Shields
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: