Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29537

EnvironmentContributingAction compatible with Workflow

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      Currently EnvironmentContributingAction is limited to AbstractBuild. A more general version should be defined which can be called from Run.getEnvironment.

          [JENKINS-29537] EnvironmentContributingAction compatible with Workflow

          Jesse Glick added a comment -

          You can use EnvironmentContributor and check for the action instead.

          Jesse Glick added a comment - You can use EnvironmentContributor and check for the action instead.

          Jesse Glick added a comment -

          …but only if JENKINS-42499 is addressed.

          Jesse Glick added a comment - …but only if  JENKINS-42499 is addressed.

          Alexander A added a comment -

          Alexander A added a comment - https://github.com/jenkinsci/jenkins/pull/2975

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/AbstractBuild.java
          core/src/main/java/hudson/model/EnvironmentContributingAction.java
          core/src/main/java/hudson/model/ParametersAction.java
          core/src/main/java/hudson/model/Run.java
          core/src/test/java/hudson/model/EnvironmentContributingActionTest.java
          core/src/test/java/hudson/model/ParametersActionTest.java
          test/src/test/java/hudson/slaves/EnvironmentVariableNodePropertyTest.java
          http://jenkins-ci.org/commit/jenkins/b3e2ed8a37531d65e32d45070aaaae450e8af543
          Log:
          JENKINS-29537 Merged #2993: amended EnvironmentContributingAction signature.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/EnvironmentContributingAction.java core/src/main/java/hudson/model/ParametersAction.java core/src/main/java/hudson/model/Run.java core/src/test/java/hudson/model/EnvironmentContributingActionTest.java core/src/test/java/hudson/model/ParametersActionTest.java test/src/test/java/hudson/slaves/EnvironmentVariableNodePropertyTest.java http://jenkins-ci.org/commit/jenkins/b3e2ed8a37531d65e32d45070aaaae450e8af543 Log: JENKINS-29537 Merged #2993: amended EnvironmentContributingAction signature.

          Oleg Nenashev added a comment -

          The API improvement has been integrated towards 2.76

          Oleg Nenashev added a comment - The API improvement has been integrated towards 2.76

          Code changed in jenkins
          User: Wisen Tanasa
          Path:
          src/integrationTest/groovy/com/ceilfors/jenkins/plugins/jiratrigger/integration/JenkinsRunner.groovy
          src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/ParameterMappingAction.groovy
          http://jenkins-ci.org/commit/jira-trigger-plugin/4cf64c12f9fcbe00d54d5fcb7f8dfe9926e35f57
          Log:
          JENKINS-46482 Use ParametersAction instead of EnvironmentContributingAction.

          Apparently EnvironmentContributingAction is not working in a pipeline job and the fix requires Jenkins core 2.76+. See JENKINS-29537.

          Compare: https://github.com/jenkinsci/jira-trigger-plugin/compare/f83ef699de31...4cf64c12f9fc

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wisen Tanasa Path: src/integrationTest/groovy/com/ceilfors/jenkins/plugins/jiratrigger/integration/JenkinsRunner.groovy src/main/groovy/com/ceilfors/jenkins/plugins/jiratrigger/ParameterMappingAction.groovy http://jenkins-ci.org/commit/jira-trigger-plugin/4cf64c12f9fcbe00d54d5fcb7f8dfe9926e35f57 Log: JENKINS-46482 Use ParametersAction instead of EnvironmentContributingAction. Apparently EnvironmentContributingAction is not working in a pipeline job and the fix requires Jenkins core 2.76+. See JENKINS-29537 . Compare: https://github.com/jenkinsci/jira-trigger-plugin/compare/f83ef699de31...4cf64c12f9fc

            jimilian Alexander A
            jglick Jesse Glick
            Votes:
            6 Vote for this issue
            Watchers:
            13 Start watching this issue

              Created:
              Updated:
              Resolved: