Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29144

SimpleBuildStep to receive EnvVars

    XMLWordPrintable

Details

    • Jenkins 2.241

    Description

      SimpleBuildStep.perform needs to be given an EnvVars argument. Otherwise there is no way for an implementation to observe any local environment variable settings.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-62723 Build fails with "java.lang.IllegalArgumentException: Method perform not found in hudson.plugins.analysis.core.HealthAwareRecorder"

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-63754 InvocationTargetException instead of AbortException

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is blocking

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-23713 Remove AbstractProject-ness from BuildStep

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-65151 Using Environment Variables in Plugins is not Possible / not Documented

          • Major - Major loss of function.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-40070 ${env.GLOBALSETTINGSNAME} invalid out of node context

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-35671 Define Run.getEnvironmentForExpansion

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-29537 EnvironmentContributingAction compatible with Workflow

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-46175 Ability to mark a SimpleBuildStep as not requiring a workspace context

          • Major - Major loss of function.
          • Closed
          links to

          Web Link Jenkins PR 4766

          Web Link workflow-basic-steps draft PR 116

          Activity

            Ascending order - Click to sort in descending order
            View 13 older comments
            zastai Tim Van Holder added a comment -

            Turns out that for my immediate purpose in my plugin, it was actually very easy to add support for getting environment variables by implementing a metastep (all my builders share a base class that implements the perform() anyway, so no SimpleBuildStep needed at all).

            The trick is to know that metasteps exist, which I didn't until I read the javadoc for isMetaStep() while going over what CoreStep does.
             

            Anyway, I've assigned this to myself and will look at setting up clones of jenkins and workflow-basic-steps-plugin to see what I can make work without breaking tests.

            And thanks for the pointer to the incrementals; that's useful info.

            zastai Tim Van Holder added a comment - Turns out that for my immediate purpose in my plugin, it was actually very easy to add support for getting environment variables by implementing a metastep (all my builders share a base class that implements the perform() anyway, so no SimpleBuildStep needed at all). The trick is to know that metasteps exist, which I didn't until I read the javadoc for isMetaStep() while going over what CoreStep does.   Anyway, I've assigned this to myself and will look at setting up clones of jenkins and workflow-basic-steps-plugin to see what I can make work without breaking tests. And thanks for the pointer to the incrementals; that's useful info.
            jglick Jesse Glick added a comment -

            The metastep system was not intended for use by domain-specific plugins, i.e. for anything other than core, wrap, and in the future perhaps checkout.

            jglick Jesse Glick added a comment - The metastep system was not intended for use by domain-specific plugins, i.e. for anything other than core , wrap , and in the future perhaps checkout .
            zastai Tim Van Holder added a comment -

            Add link to draft plugin PR.

            zastai Tim Van Holder added a comment - Add link to draft plugin PR.
            oleg_nenashev Oleg Nenashev added a comment -

            The Jenkins core patch was released in Jenkins 2.241

            oleg_nenashev Oleg Nenashev added a comment - The Jenkins core patch was released in Jenkins 2.241
            zastai Tim Van Holder added a comment -

            Technically this issue won't be solved until workflow-basic-steps is updated too.

            zastai Tim Van Holder added a comment - Technically this issue won't be solved until workflow-basic-steps is updated too.

            People

              zastai Tim Van Holder
              jglick Jesse Glick
              Votes:
              3 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: