Code changed in jenkins
User: Stephen Connolly
Path:
core/src/main/java/hudson/slaves/NodeProvisioner.java
http://jenkins-ci.org/commit/jenkins/4f0ca16b01abcd5ac84a9259736c2d96b1712354
Log:
[FIXED JENKINS-29568] A better fix

• 252e1296099e838b8fba52221910442e0a757db4 doesn't work for all cases as there are code paths
  where a pending launch can be removed from the pending list and not have spent() called.
• There was no reason for iterating the list twice anyway, as all of this takes place with the locks held
• My notifying each one as we process, if there is an Error, we will not leave any stranded. The next run
  through, if there is one, will cover those instances.

Integrated in jenkins_main_trunk #4226
[FIXED JENKINS-29568] A better fix (Revision 4f0ca16b01abcd5ac84a9259736c2d96b1712354)

Result = UNSTABLE
stephen connolly : 4f0ca16b01abcd5ac84a9259736c2d96b1712354
Files :

• core/src/main/java/hudson/slaves/NodeProvisioner.java

Test failures are in completely unrelated code.

hudson.model.DownloadService2Test.updateNow
hudson.model.UpdateCenter2Test.install
hudson.model.UpdateCenterTest.data
hudson.slaves.CommandLauncherTest.commandFails
hudson.tasks.BuildTriggerTest.downstreamProjectShouldObserveCompletedParent

Most likely a false warning possibly related to Jenkins infra outages as I have been seeing intermittent 503's on the main jenkins-ci.org today

Code changed in jenkins
User: Daniel Beck
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/1598a464ff7973cbe6d3d6aa2493085a4a0646ec
Log:
Noting #1770 in 1.622, JENKINS-29568

Code changed in jenkins
User: Stephen Connolly
Path:
core/src/main/java/hudson/slaves/NodeProvisioner.java
http://jenkins-ci.org/commit/jenkins/db1e2d2a199f7231f85809234cc1c703d3cb67a0
Log:
[FIXED JENKINS-29568] A better fix

• 252e1296099e838b8fba52221910442e0a757db4 doesn't work for all cases as there are code paths
  where a pending launch can be removed from the pending list and not have spent() called.
• There was no reason for iterating the list twice anyway, as all of this takes place with the locks held
• My notifying each one as we process, if there is an Error, we will not leave any stranded. The next run
  through, if there is one, will cover those instances.

(cherry picked from commit 4f0ca16b01abcd5ac84a9259736c2d96b1712354)

Compare: https://github.com/jenkinsci/jenkins/compare/fea12f76f50e...db1e2d2a199f

Integrated in jenkins_main_trunk #4292
[FIXED JENKINS-29568] A better fix (Revision db1e2d2a199f7231f85809234cc1c703d3cb67a0)

Result = UNSTABLE
ogondza : db1e2d2a199f7231f85809234cc1c703d3cb67a0
Files :

• core/src/main/java/hudson/slaves/NodeProvisioner.java