Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29784

DSL Job View shows many copies of Generated Items

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • job-dsl-plugin
    • Job DSL plugin version 1.35
      Jenkins version 1.612
    • job-dsl 1.75

      I am creating a DSL job that creates and administrates the building of 3 other jobs. I want to watch the progress of each job's build, and when one finishes successfully, create the next job and kick off a build, then watch it and so on. I have done this successfully by creating 3 separate DSL scripts in the DSL job, which are separated by a groovy script in between that watches and waits for each job to finish as it is created and built. However, doing so creates multiple copies of "Generated Items" on the main view of the DSL job (picture attached). Based on what I can tell, it seems that if you create multiple jobs within one DSL script, this does not happen, but only when you create jobs with multiple different DSL scripts in the same DSL job.

      This is a small issue but eventually I hope to have a DSL job that created many more than just 3 other jobs, doing this would greatly clutter the DSL job's view. I hope this is an easy thing to fix!

      Thank you!

        1. Screenshot.png
          Screenshot.png
          30 kB
        2. c0898f68-2ec0-4666-9af7-15f8db7f5e01.png
          c0898f68-2ec0-4666-9af7-15f8db7f5e01.png
          29 kB

          [JENKINS-29784] DSL Job View shows many copies of Generated Items

          Ian Tait created issue -
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 164860 ] New: JNJira + In-Review [ 181716 ]
          Nikita Lopatin made changes -
          Attachment New: c0898f68-2ec0-4666-9af7-15f8db7f5e01.png [ 38533 ]

          Nikita Lopatin added a comment -

          Same here. I am using Jenkins v2.46.3 and Job DSL v1.63

          When I configure my seed job to generate other jobs depending on the items I checked from checkbox list, and then check more that one, I get copies of these "generated projects" list:

           

          This seed job is also generated by a dsl job, so I am using a following simple code in a .groovy script:

           

          // simple code
job('projects_seed') {
    label('publisher')
    logRotator(-1, 10, -1, -1)
    parameters {
        booleanParam('project1',false)
        booleanParam('project2',false)
        booleanParam('project3',false)
        booleanParam('project4',false)
        booleanParam('project5',false)
    }
    steps {
        batchFile('svn checkout %REPO% %WORKSPACE% --username %SVN_USER% --password %SVN_PASS%')
        conditionalSteps {
                condition {booleanCondition ('${project1}')}
                runner('DontRun')
                steps {
                    dsl {
                        external('jobs/project1.groovy')
                    }
                }
        }
        conditionalSteps {
            condition {booleanCondition ('${project2}')}
            runner('DontRun')
            steps {
                dsl {
                    external('jobs/project2.groovy')
                }
            }
        }
        conditionalSteps {
            condition {booleanCondition ('${project3}')}
            runner('DontRun')
            steps {
                dsl {
                    external('jobs/project3.groovy')
                }
            }
        }
        conditionalSteps {
            condition {booleanCondition ('${project4}')}
            runner('DontRun')
            steps {
                dsl {
                    external('jobs/project4.groovy')
                }
            }
        }
        conditionalSteps {
            condition {booleanCondition ('${project5}')}
            runner('DontRun')
            steps {
                dsl {
                    external('jobs/project5.groovy')
                }
            }
        }
    }

    publishers {
        wsCleanup()
    }
    wrappers {
        preBuildCleanup()
        timestamps()
        injectPasswords {
            injectGlobalPasswords()
        }
    }

}

           

          One of the generated .groovy scripts generates more than one job if that means something. 

           

          This is not a critical problem, but kina hurts eyes a bit, so I'm looking forward to hear from you

           

          Nikita Lopatin added a comment - Same here. I am using Jenkins v2.46.3 and Job DSL v1.63 When I configure my seed job to generate other jobs depending on the items I checked from checkbox list, and then check more that one, I get copies of these "generated projects" list:   This seed job is also generated by a dsl job, so I am using a following simple code in a .groovy script:   // simple code job( 'projects_seed' ) { label( 'publisher' ) logRotator(-1, 10, -1, -1) parameters { booleanParam( 'project1' , false ) booleanParam( 'project2' , false ) booleanParam( 'project3' , false ) booleanParam( 'project4' , false ) booleanParam( 'project5' , false ) } steps { batchFile( 'svn checkout %REPO% %WORKSPACE% --username %SVN_USER% --password %SVN_PASS%' ) conditionalSteps { condition {booleanCondition ( '${project1}' )} runner( 'DontRun' ) steps { dsl { external( 'jobs/project1.groovy' ) } } } conditionalSteps { condition {booleanCondition ( '${project2}' )} runner( 'DontRun' ) steps { dsl { external( 'jobs/project2.groovy' ) } } } conditionalSteps { condition {booleanCondition ( '${project3}' )} runner( 'DontRun' ) steps { dsl { external( 'jobs/project3.groovy' ) } } } conditionalSteps { condition {booleanCondition ( '${project4}' )} runner( 'DontRun' ) steps { dsl { external( 'jobs/project4.groovy' ) } } } conditionalSteps { condition {booleanCondition ( '${project5}' )} runner( 'DontRun' ) steps { dsl { external( 'jobs/project5.groovy' ) } } } } publishers { wsCleanup() } wrappers { preBuildCleanup() timestamps() injectPasswords { injectGlobalPasswords() } } }   One of the generated .groovy scripts generates more than one job if that means something.    This is not a critical problem, but kina hurts eyes a bit, so I'm looking forward to hear from you  
          Daniel Spilker made changes -
          Link New: This issue is duplicated by JENKINS-48223 [ JENKINS-48223 ]

          Lucie Votypkova added a comment -

          Hello,

          I fixed it in this pull request https://github.com/jenkinsci/job-dsl-plugin/pull/1190.

          Your problem is caused by multiple job-dsl build step - everyone adds its own action - so there is many actions of added items instead of one action with all. I changed it the way that if action for given build exists, it is not added the new one - new generated objects are included by the old one. 

          It should fix the problem with removing all jobs (views...) created by previous steps when Action for removed job/views/config is checked.

          Lucie Votypkova added a comment - Hello, I fixed it in this pull request https://github.com/jenkinsci/job-dsl-plugin/pull/1190. Your problem is caused by multiple job-dsl build step - everyone adds its own action - so there is many actions of added items instead of one action with all. I changed it the way that if action for given build exists, it is not added the new one - new generated objects are included by the old one.  It should fix the problem with removing all jobs (views...) created by previous steps when Action for removed job/views/config is checked.
          Lucie Votypkova made changes -
          Link New: This issue causes JENKINS-44142 [ JENKINS-44142 ]
          Daniel Spilker made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Fixed but Unreleased [ 10203 ]
          Daniel Spilker made changes -
          Released As New: job-dsl 1.75
          Status Original: Fixed but Unreleased [ 10203 ] New: Closed [ 6 ]

            daspilker Daniel Spilker
            thetaiter Ian Tait
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: