Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29942

Add findbugs to extensible-choice-parameter plugin

    XMLWordPrintable

    Details

    • Similar Issues:

      Attachments

        Activity

        Hide
        ikedam ikedam added a comment -
        • ParameterDefinition implements Serializable.
        • ExtensibleChoiceParameterDefinition implements Serializable.
        • ChoiceListProvider is a member of ExtensibleChoiceParameterDefinition and have to implement Serializable.
        • SystemGroovyChoiceListProvider holds AbstractProject where it is contained.
        • AbstractProject doesn't implement Serializable.
        Show
        ikedam ikedam added a comment - ParameterDefinition implements Serializable . ExtensibleChoiceParameterDefinition implements Serializable . ChoiceListProvider is a member of ExtensibleChoiceParameterDefinition and have to implement Serializable . SystemGroovyChoiceListProvider holds AbstractProject where it is contained. AbstractProject doesn't implement Serializable .
        Show
        ikedam ikedam added a comment - https://github.com/jenkinsci/extensible-choice-parameter-plugin/pull/20
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -
        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: pom.xml http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/7029286f77d37e33ede78808063f7f236cd5ceca Log: JENKINS-29942 Enabled findbugs.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: ikedam
        Path:
        src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/AddEditedChoiceListProvider.java
        src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceListProvider.java
        src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/FilenameChoiceListProvider.java
        src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider.java
        src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/SystemGroovyChoiceListProvider.java
        src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/TextareaChoiceListProvider.java
        src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
        http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/652cf12e39bb639d1407f1ad2a93462d18de2ec2
        Log:
        JENKINS-29942 Make ChoiceListProvider Serializable.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/AddEditedChoiceListProvider.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceListProvider.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/FilenameChoiceListProvider.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/SystemGroovyChoiceListProvider.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/TextareaChoiceListProvider.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/652cf12e39bb639d1407f1ad2a93462d18de2ec2 Log: JENKINS-29942 Make ChoiceListProvider Serializable.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: ikedam
        Path:
        src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchRunListener.java
        src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListEntry.java
        http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/1777c06a7d91d413b2e6d7400889e0726023dc83
        Log:
        JENKINS-29942 Fixed problems pointed by findbugs.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceWatchRunListener.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListEntry.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/1777c06a7d91d413b2e6d7400889e0726023dc83 Log: JENKINS-29942 Fixed problems pointed by findbugs.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: ikedam
        Path:
        src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/SystemGroovyChoiceListProvider.java
        src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/SystemGroovyChoiceListProviderJenkinsTest.java
        http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/6619f61a9d71c90f98ae3b8909008452ad192248
        Log:
        JENKINS-29942 Make project in SystemGroovyChoiceListProvider transient not to break Serializable constraint.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/SystemGroovyChoiceListProvider.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/SystemGroovyChoiceListProviderJenkinsTest.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/6619f61a9d71c90f98ae3b8909008452ad192248 Log: JENKINS-29942 Make project in SystemGroovyChoiceListProvider transient not to break Serializable constraint.

          People

          Assignee:
          ikedam ikedam
          Reporter:
          ikedam ikedam
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

            Dates

            Created:
            Updated:
            Resolved: