Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30292

MSTestRunner Plugin not visible in Conditional BuildStep Plugin

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Please make MSTestRunner Plugin useable in Conditional BuildStep Plugin. MSTest is not selected as step in a conditional task.

      The Descriptor does not extend hudson.tasks.BuildStepDescriptor

        Attachments

          Activity

          Hide
          ido_ran Ido Ran added a comment -

          Can you please direct me to docs about the difference between ToolDescriptor and BuildStepDescriptor?

          Show
          ido_ran Ido Ran added a comment - Can you please direct me to docs about the difference between ToolDescriptor and BuildStepDescriptor?
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ido Ran
          Path:
          src/main/java/org/jenkinsci/plugins/MsTestBuilder.java
          http://jenkins-ci.org/commit/mstestrunner-plugin/85bd0dffc74451cf5e116f5bc94d1a8249bd1e04
          Log:
          Fix JENKINS-30292 - Not visible in Conditional BuildStep Plugin

          Builder descriptor now inherit BuildStepDescriptor so it will be visible in conditional BuildStep plugin

          Compare: https://github.com/jenkinsci/mstestrunner-plugin/compare/f2edb3618df7...85bd0dffc744

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ido Ran Path: src/main/java/org/jenkinsci/plugins/MsTestBuilder.java http://jenkins-ci.org/commit/mstestrunner-plugin/85bd0dffc74451cf5e116f5bc94d1a8249bd1e04 Log: Fix JENKINS-30292 - Not visible in Conditional BuildStep Plugin Builder descriptor now inherit BuildStepDescriptor so it will be visible in conditional BuildStep plugin Compare: https://github.com/jenkinsci/mstestrunner-plugin/compare/f2edb3618df7...85bd0dffc744
          Hide
          ido_ran Ido Ran added a comment -

          Fixed in version 1.2.0 of MSTestRunner plugin

          Show
          ido_ran Ido Ran added a comment - Fixed in version 1.2.0 of MSTestRunner plugin
          Hide
          philippjenni Jenni Philipp added a comment -

          I can't say what the difference between this 2 interfaces is. But here is the documentation from Conditional Build Step Plugin:

          Missing builder
          If you're not able to add the builder of your choice within a conditional build step (because it's not available within the dropdown), then this is likely because the builder does not provide a @DataBoundConstructor constructor and/or the Descriptor does not extend hudson.tasks.BuildStepDescriptor. For non programmers: the plugin you would like to use does not yet follow the newest Jenkins coding guidelines. Without this, the conditional buildstep plugin is not able to work with it.

          https://wiki.jenkins-ci.org/display/JENKINS/Conditional+BuildStep+Plugin

          Show
          philippjenni Jenni Philipp added a comment - I can't say what the difference between this 2 interfaces is. But here is the documentation from Conditional Build Step Plugin: Missing builder If you're not able to add the builder of your choice within a conditional build step (because it's not available within the dropdown), then this is likely because the builder does not provide a @DataBoundConstructor constructor and/or the Descriptor does not extend hudson.tasks.BuildStepDescriptor. For non programmers: the plugin you would like to use does not yet follow the newest Jenkins coding guidelines. Without this, the conditional buildstep plugin is not able to work with it. https://wiki.jenkins-ci.org/display/JENKINS/Conditional+BuildStep+Plugin
          Hide
          philippjenni Jenni Philipp added a comment -

          Works fine now. Thanks

          Show
          philippjenni Jenni Philipp added a comment - Works fine now. Thanks

            People

            Assignee:
            ido_ran Ido Ran
            Reporter:
            philippjenni Jenni Philipp
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: