In the project view (job page) the links below the last trend graph are not clickable since the footer overlaps these links. It happens only if you have several trend graphs so you need to scroll the page in order to view the bottom one.

      In order to reproduce this bug, the test case could be adapted so that the analysis-collector plug-in is running this test.

          [JENKINS-30304] Footer hides trend graph links

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/org/jenkinsci/test/acceptance/po/Job.java
          src/test/java/plugins/AbstractAnalysisTest.java
          http://jenkins-ci.org/commit/acceptance-test-harness/e38955e49e1ef6d147d8b09191d59674e46022f3
          Log:
          JENKINS-29900 Improved test so that detail trend graph is verified, too.

          Still has a workaround for JENKINS-30304.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/org/jenkinsci/test/acceptance/po/Job.java src/test/java/plugins/AbstractAnalysisTest.java http://jenkins-ci.org/commit/acceptance-test-harness/e38955e49e1ef6d147d8b09191d59674e46022f3 Log: JENKINS-29900 Improved test so that detail trend graph is verified, too. Still has a workaround for JENKINS-30304 .

          drulli, Could you provide the OS and web browser (and version)?

          Manuel Recena Soto added a comment - drulli , Could you provide the OS and web browser (and version)?

          Ulli Hafner added a comment -

          I noticed that on OSX with either latest firefox and chrome while writing an acceptance test for the analysis-plug-in. You can remove the if in https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/AbstractAnalysisTest.java#L173 and then the test will fail for the analysis-collector plug-in. Or should I prepare the test case for you?

          Ulli Hafner added a comment - I noticed that on OSX with either latest firefox and chrome while writing an acceptance test for the analysis-plug-in. You can remove the if in https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/AbstractAnalysisTest.java#L173 and then the test will fail for the analysis-collector plug-in. Or should I prepare the test case for you?

          drulli, I think this PR solves the issue.

          Manuel Recena Soto added a comment - drulli , I think this PR solves the issue.

          drulli, Should this method be like this?

          private void verifyTrendGraphDetails(final FreeStyleJob job, final AnalysisAction action) {
              List<WebElement> graphLinks = job.all(By.linkText("Enlarge"));
              for (int i = 0; i < graphLinks.size(); i++) {
                  graphLinks.get(i).click();
                  assertThatProjectPageTrendIsCorrect(job, action, "../../");
              }
          }
          

          Manuel Recena Soto added a comment - drulli , Should this method be like this? private void verifyTrendGraphDetails( final FreeStyleJob job, final AnalysisAction action) { List<WebElement> graphLinks = job.all(By.linkText( "Enlarge" )); for ( int i = 0; i < graphLinks.size(); i++) { graphLinks.get(i).click(); assertThatProjectPageTrendIsCorrect(job, action, "../../" ); } }

          Ulli Hafner added a comment -

          No, it should be

                  List<WebElement> graphLinks = job.all(By.linkText("Enlarge"));
                  graphLinks.get(graphLinks.size() - 1).click();
                  assertThatProjectPageTrendIsCorrect(job, action, "../../");
          

          Ulli Hafner added a comment - No, it should be List<WebElement> graphLinks = job.all(By.linkText( "Enlarge" )); graphLinks.get(graphLinks.size() - 1).click(); assertThatProjectPageTrendIsCorrect(job, action, "../../" );

          drulli, Please, find linked two PR involved.

          Manuel Recena Soto added a comment - drulli , Please, find linked two PR involved.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: changelog.html http://jenkins-ci.org/commit/jenkins/67c13dab316130468f101a300a3f0f388b8d6736 Log: Noting JENKINS-30304 and JENKINS-3195 from https://github.com/jenkinsci/jenkins/pull/1908

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/test/java/plugins/AbstractAnalysisTest.java
          src/test/java/plugins/AnalysisCollectorPluginTest.java
          http://jenkins-ci.org/commit/acceptance-test-harness/9a50640c808039f7a26e20ea5fdeae68712292e2
          Log:
          JENKINS-30304 Added acceptance test.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/test/java/plugins/AbstractAnalysisTest.java src/test/java/plugins/AnalysisCollectorPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/9a50640c808039f7a26e20ea5fdeae68712292e2 Log: JENKINS-30304 Added acceptance test.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/test/java/plugins/AbstractAnalysisTest.java
          http://jenkins-ci.org/commit/acceptance-test-harness/f3b8c7c2b2b642b2d48e32c048fc08e3751a13d5
          Log:
          JENKINS-30304 Removed workaround for Jenkins releases < 1.640. (LTS is now at 1.642)

          Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/7a98fbe70123...f3b8c7c2b2b6

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/test/java/plugins/AbstractAnalysisTest.java http://jenkins-ci.org/commit/acceptance-test-harness/f3b8c7c2b2b642b2d48e32c048fc08e3751a13d5 Log: JENKINS-30304 Removed workaround for Jenkins releases < 1.640. (LTS is now at 1.642) Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/7a98fbe70123...f3b8c7c2b2b6

            recena Manuel Recena Soto
            drulli Ulli Hafner
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: