Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30466

plugin does not return error if unshelve fails

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • p4-plugin
    • None

      We have detected a few time that the unshelve fails for various reasons:
      Below is one such example, the p4 plugin should throw an error so it is obvious to the Jenkins job that there was an scm errom.

      p4 unshelve -f -s141408 -cdefault

      Librarian checkout /p4/mlb.1/depots/atf/int_mlb/jenkins_batch/atf_l1phy_anritsurtd_build_step.bat failed.
      Error opening librarian file /p4/mlb.1/depots/atf/int_mlb/jenkins_batch/atf_l1phy_anritsurtd_build_step.bat revision 1.141408.
      open for read: /p4/mlb.1/depots/atf/int_mlb/jenkins_batch/atf_l1phy_anritsurtd_build_step.bat,d/1.141408.gz: No such file or directory

          [JENKINS-30466] plugin does not return error if unshelve fails

          Harrison Ting added a comment - - edited

          I just ran into this as well.

          p4 unshelve -f -s2645515 -cdefault
          
          //KeystoneFoundation/Main/Build/Foundation/assemble_unity3d_package.py - needs fromfile //KeystoneFoundation/Main/Build/assemble_unity3d_package.py 

          It looks like the problem is that the `ClientHelper.unshelveFiles` method only checks for a few specific errors ("also opened by", "No such file(s)", "exclusive file already opened", "no file(s) to unshelve"), and ignores others: https://github.com/jenkinsci/p4-plugin/blob/1dc31cd2e99b6419c5bc90fc62728a33d7c665ad/src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java#L978

          Harrison Ting added a comment - - edited I just ran into this as well. p4 unshelve -f -s2645515 -cdefault //KeystoneFoundation/Main/Build/Foundation/assemble_unity3d_package.py - needs fromfile //KeystoneFoundation/Main/Build/assemble_unity3d_package.py It looks like the problem is that the `ClientHelper.unshelveFiles` method only checks for a few specific errors ("also opened by", "No such file(s)", "exclusive file already opened", "no file(s) to unshelve"), and ignores others: https://github.com/jenkinsci/p4-plugin/blob/1dc31cd2e99b6419c5bc90fc62728a33d7c665ad/src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java#L978

            Unassigned Unassigned
            mornejoubert Morne Joubert
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: