Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30488

Use Stapler adjunct to load JQuery

    XMLWordPrintable

Details

    Description

      The Summary Report Plug-in loads a JQuery file in Jelly. If other plug-ins have already loaded JQuery and plug-ins, it may break the behaviour in these plug-ins.

      A solution would be to use Stapler adjuncts to load JQuery if not already loaded.

      Thanks!
      Bruno

      Attachments

        Issue Links

          is related to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. JENKINS-31161 Update HTMLUnit in Jenkins Core

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            ioannis Ioannis Moutsatsos added a comment -

            Ha, funny that my search for Stapler Adjunct brought me here! Going in circles kinow ?

            ioannis Ioannis Moutsatsos added a comment - Ha, funny that my search for Stapler Adjunct brought me here! Going in circles kinow ?
            kinow Bruno P. Kinoshita added a comment -

            Haha, I had forgotten about this one. Will take a look if perhaps I can send a PR to the plug-in

            kinow Bruno P. Kinoshita added a comment - Haha, I had forgotten about this one. Will take a look if perhaps I can send a PR to the plug-in
            kinow Bruno P. Kinoshita added a comment -

            Ah, now I remember. I didn't submit a pull request because the plug-in uses other JS and CSS files too: https://github.com/jenkinsci/summary_report-plugin/blob/8c3ce098d8d8aa0e272e9cf959857f3d8ae7a10b/src/main/resources/hudson/plugins/summary_report/ACIPluginBuildAction/summary.jelly#L15-L24

            If it were a one-line change it'd be easy to quickly prepare a PR. But will leave this one up for the maintainers or a user with more time to implement & test it.

            kinow Bruno P. Kinoshita added a comment - Ah, now I remember. I didn't submit a pull request because the plug-in uses other JS and CSS files too: https://github.com/jenkinsci/summary_report-plugin/blob/8c3ce098d8d8aa0e272e9cf959857f3d8ae7a10b/src/main/resources/hudson/plugins/summary_report/ACIPluginBuildAction/summary.jelly#L15-L24 If it were a one-line change it'd be easy to quickly prepare a PR. But will leave this one up for the maintainers or a user with more time to implement & test it.

            People

              Unassigned Unassigned
              kinow Bruno P. Kinoshita
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: