Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30564

timeoutMinutesElasticDefault should be used until numberOfBuilds is not reached out

      If you have the following configuration in a job :
      Timeout as a percentage of recent non-failing builds 200%
      Number of Builds 5 (Number of builds to consider computing average duration)
      Timeout minutes 45

      Then, you might have one successful build for a job, but doing nothing (no build necessary), thus with very little execution time (less than 2 min) .

      Then, you will get timeout errors when the time elapsed was 3 min and thus you will not be able to run successfully the job when the build was necessary. You needed to remove the successful execution.

      A better behavior would be to use the average execution time only if number of builds is already bigger than the defined number of builds (5 in this case).

      Before you have reached that number, the plugin should use the default defined timeout (here 45 min).

          [JENKINS-30564] timeoutMinutesElasticDefault should be used until numberOfBuilds is not reached out

          Code changed in jenkins
          User: fbelzunc
          Path:
          src/main/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategy.java
          src/main/resources/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategy/config.jelly
          http://jenkins-ci.org/commit/build-timeout-plugin/697eafc31c63c015fd5720fee762bba35fb47800
          Log:
          [FIXED JENKINS-30564] Add failSafeTimeoutDuration checkbox

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: fbelzunc Path: src/main/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategy.java src/main/resources/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategy/config.jelly http://jenkins-ci.org/commit/build-timeout-plugin/697eafc31c63c015fd5720fee762bba35fb47800 Log: [FIXED JENKINS-30564] Add failSafeTimeoutDuration checkbox

          Code changed in jenkins
          User: fbelzunc
          Path:
          src/test/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategyTest.java
          http://jenkins-ci.org/commit/build-timeout-plugin/264a9a73bbf9958d9dab48cae93145185a50ebd0
          Log:
          JENKINS-30564 Add tests for the FailSafeTimeoutDuration feature

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: fbelzunc Path: src/test/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategyTest.java http://jenkins-ci.org/commit/build-timeout-plugin/264a9a73bbf9958d9dab48cae93145185a50ebd0 Log: JENKINS-30564 Add tests for the FailSafeTimeoutDuration feature

          Code changed in jenkins
          User: ikedam
          Path:
          src/test/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategyJenkinsTest.java
          src/test/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategyTest.java
          http://jenkins-ci.org/commit/build-timeout-plugin/2c055aa4b244287f6a80e134654867e70c550f09
          Log:
          JENKINS-30564 Added tests for `failSafeTimeoutDuration`.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/test/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategyJenkinsTest.java src/test/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategyTest.java http://jenkins-ci.org/commit/build-timeout-plugin/2c055aa4b244287f6a80e134654867e70c550f09 Log: JENKINS-30564 Added tests for `failSafeTimeoutDuration`.

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategy.java
          src/main/resources/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategy/config.jelly
          src/test/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategyJenkinsTest.java
          src/test/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategyTest.java
          http://jenkins-ci.org/commit/build-timeout-plugin/a46cf2686962685caa57adbf04d5ddfe22700747
          Log:
          Merge pull request #49 from ikedam/feature/JENKINS-30564_failSafeTimeoutDuration

          JENKINS-30564 Failsafe timeout duration for ElasticTimeoutStrategy

          Compare: https://github.com/jenkinsci/build-timeout-plugin/compare/8c0c930f5ba5...a46cf2686962

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategy.java src/main/resources/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategy/config.jelly src/test/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategyJenkinsTest.java src/test/java/hudson/plugins/build_timeout/impl/ElasticTimeOutStrategyTest.java http://jenkins-ci.org/commit/build-timeout-plugin/a46cf2686962685caa57adbf04d5ddfe22700747 Log: Merge pull request #49 from ikedam/feature/ JENKINS-30564 _failSafeTimeoutDuration JENKINS-30564 Failsafe timeout duration for ElasticTimeoutStrategy Compare: https://github.com/jenkinsci/build-timeout-plugin/compare/8c0c930f5ba5...a46cf2686962

          ikedam added a comment -

          Released build-timeout-1.16 providing failSafeTimeoutDuration.
          It will be available in the update center in a day.

          ikedam added a comment - Released build-timeout-1.16 providing failSafeTimeoutDuration. It will be available in the update center in a day.

            fbelzunc Félix Belzunce Arcos
            fbelzunc Félix Belzunce Arcos
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: