Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30592

An AC Reactive Reference is always displayed unless it references a parameter

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • active-choices-plugin
    • None
    • Active Choices Plugin v 1.2

      When an AC Reactive Reference parameter does not reference any parameters, even though it is set to 'Hidden HTML' it is still displayed in the UI.

      Current Workaround: Include a build parameter (or even a no existent dummy parameter) as a Referenced parameter to hide a 'Hidden HTML' type reactive reference.

      However, th is workaround hack should not be necessary. The parameter option type should be honored independent of the referenced parameters.

          [JENKINS-30592] An AC Reactive Reference is always displayed unless it references a parameter

          Bruno P. Kinoshita added a comment -

          Oh, successfully reproduced the issue. Interesting. Not really sure why that's happening, but I believe it might be easy to fix.

          Bruno P. Kinoshita added a comment - Oh, successfully reproduced the issue. Interesting. Not really sure why that's happening, but I believe it might be easy to fix.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/main/resources/org/biouno/unochoice/DynamicReferenceParameter/index.jelly
          http://jenkins-ci.org/commit/active-choices-plugin/c603534b41ac9ce6af48a99bd5dbb22cf7900a21
          Log:
          [FIXED JENKINS-30592] Hide hidden formatted parameters right after the elements are created in the DOM

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/resources/org/biouno/unochoice/DynamicReferenceParameter/index.jelly http://jenkins-ci.org/commit/active-choices-plugin/c603534b41ac9ce6af48a99bd5dbb22cf7900a21 Log: [FIXED JENKINS-30592] Hide hidden formatted parameters right after the elements are created in the DOM

          Bruno P. Kinoshita added a comment -

          Fixed, but we will need to run some manual tests to make sure we don't introduce a regression here.

          The parameters marked to be hidden, were being hidden during a for loop for each referenced parameter. I believe this may speed up the plug-in behaviour a little bit, and also fix the issue reported.

          Unit tests (Java and JS) pass with no errors. Parameters seem to work fine in the browser, but might still be a good idea to run some further testing before releasing a with 1.3. Will attach a plug-in version here with the fix.

          Bruno P. Kinoshita added a comment - Fixed, but we will need to run some manual tests to make sure we don't introduce a regression here. The parameters marked to be hidden, were being hidden during a for loop for each referenced parameter. I believe this may speed up the plug-in behaviour a little bit, and also fix the issue reported. Unit tests (Java and JS) pass with no errors. Parameters seem to work fine in the browser, but might still be a good idea to run some further testing before releasing a with 1.3. Will attach a plug-in version here with the fix.

          Bruno P. Kinoshita added a comment -

          Fixed in 1.3

          Bruno P. Kinoshita added a comment - Fixed in 1.3

            kinow Bruno P. Kinoshita
            ioannis Ioannis Moutsatsos
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: