Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30705

Optimize TagCloud size calculation

    XMLWordPrintable

Details

    Description

      On large enough instance, calculating weights for TagCloud can take significant amount of the time (~ 90% of time) needed to render /computer/XXX page.

      Handling GET /hudson/computer/XXX/ : ajp-127.0.0.1-8009-108 Computer/index.jelly
java.util.ArrayList.size(ArrayList.java:177)
java.util.AbstractList$Itr.hasNext(AbstractList.java:339)
hudson.Util.filter(Util.java:103)
hudson.Util.filter(Util.java:115)
hudson.matrix.AxisList.subList(AxisList.java:66)
hudson.matrix.MatrixConfiguration.getAssignedLabel(MatrixConfiguration.java:301)
hudson.model.Label.getTiedJobCount(Label.java:392)
hudson.model.Node$1.weight(Node.java:234)
hudson.model.Node$1.weight(Node.java:232)
hudson.util.TagCloud.<init>(TagCloud.java:73)
hudson.model.Node.getLabelCloud(Node.java:232)
sun.reflect.GeneratedMethodAccessor123002.invoke(Unknown Source)

      Attachments

        Issue Links

          links to

          Web Link PR #1843

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4296
            [FIXED JENKINS-30705] Optimize TagCloud calculation (Revision 1b852010568dc3b21c0c296e2f0a2d6ff0b8bed3)
            JENKINS-30705 Update the Label#getTiedJobCount javadoc (Revision e1cdc2a6f0517217cfa8a0c0afc25592cea1e655)
            JENKINS-30705 Reset cache for exact results in unittest (Revision 52f9172c69bf7983e385e5dce1d962110c8a5b0e)

            Result = UNSTABLE
            ogondza : 1b852010568dc3b21c0c296e2f0a2d6ff0b8bed3
            Files :

            • core/src/main/java/hudson/model/Label.java

            ogondza : e1cdc2a6f0517217cfa8a0c0afc25592cea1e655
            Files :

            • core/src/main/java/hudson/model/Label.java

            ogondza : 52f9172c69bf7983e385e5dce1d962110c8a5b0e
            Files :

            • test/src/test/java/hudson/model/NodeTest.java
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4296 [FIXED JENKINS-30705] Optimize TagCloud calculation (Revision 1b852010568dc3b21c0c296e2f0a2d6ff0b8bed3) JENKINS-30705 Update the Label#getTiedJobCount javadoc (Revision e1cdc2a6f0517217cfa8a0c0afc25592cea1e655) JENKINS-30705 Reset cache for exact results in unittest (Revision 52f9172c69bf7983e385e5dce1d962110c8a5b0e) Result = UNSTABLE ogondza : 1b852010568dc3b21c0c296e2f0a2d6ff0b8bed3 Files : core/src/main/java/hudson/model/Label.java ogondza : e1cdc2a6f0517217cfa8a0c0afc25592cea1e655 Files : core/src/main/java/hudson/model/Label.java ogondza : 52f9172c69bf7983e385e5dce1d962110c8a5b0e Files : test/src/test/java/hudson/model/NodeTest.java
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/java/hudson/model/Label.java
            http://jenkins-ci.org/commit/jenkins/9bebf2101c00e8c41c60853849cb1b3361bf8444
            Log:
            [FIXED JENKINS-30705] Optimize TagCloud calculation

            (cherry picked from commit 1b852010568dc3b21c0c296e2f0a2d6ff0b8bed3)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/model/Label.java http://jenkins-ci.org/commit/jenkins/9bebf2101c00e8c41c60853849cb1b3361bf8444 Log: [FIXED JENKINS-30705] Optimize TagCloud calculation (cherry picked from commit 1b852010568dc3b21c0c296e2f0a2d6ff0b8bed3)
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/java/hudson/model/Label.java
            http://jenkins-ci.org/commit/jenkins/c45ce21dd8064576c8f6fef15b6c9292c903d43e
            Log:
            JENKINS-30705 Update the Label#getTiedJobCount javadoc

            (cherry picked from commit e1cdc2a6f0517217cfa8a0c0afc25592cea1e655)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/model/Label.java http://jenkins-ci.org/commit/jenkins/c45ce21dd8064576c8f6fef15b6c9292c903d43e Log: JENKINS-30705 Update the Label#getTiedJobCount javadoc (cherry picked from commit e1cdc2a6f0517217cfa8a0c0afc25592cea1e655)
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            test/src/test/java/hudson/model/NodeTest.java
            http://jenkins-ci.org/commit/jenkins/7d260f317bb79c6e7f02b62f99a6819e8db26cfd
            Log:
            JENKINS-30705 Reset cache for exact results in unittest

            (cherry picked from commit 52f9172c69bf7983e385e5dce1d962110c8a5b0e)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: test/src/test/java/hudson/model/NodeTest.java http://jenkins-ci.org/commit/jenkins/7d260f317bb79c6e7f02b62f99a6819e8db26cfd Log: JENKINS-30705 Reset cache for exact results in unittest (cherry picked from commit 52f9172c69bf7983e385e5dce1d962110c8a5b0e)
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4358
            [FIXED JENKINS-30705] Optimize TagCloud calculation (Revision 9bebf2101c00e8c41c60853849cb1b3361bf8444)
            JENKINS-30705 Update the Label#getTiedJobCount javadoc (Revision c45ce21dd8064576c8f6fef15b6c9292c903d43e)
            JENKINS-30705 Reset cache for exact results in unittest (Revision 7d260f317bb79c6e7f02b62f99a6819e8db26cfd)

            Result = UNSTABLE
            ogondza : 9bebf2101c00e8c41c60853849cb1b3361bf8444
            Files :

            • core/src/main/java/hudson/model/Label.java

            ogondza : c45ce21dd8064576c8f6fef15b6c9292c903d43e
            Files :

            • core/src/main/java/hudson/model/Label.java

            ogondza : 7d260f317bb79c6e7f02b62f99a6819e8db26cfd
            Files :

            • test/src/test/java/hudson/model/NodeTest.java
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4358 [FIXED JENKINS-30705] Optimize TagCloud calculation (Revision 9bebf2101c00e8c41c60853849cb1b3361bf8444) JENKINS-30705 Update the Label#getTiedJobCount javadoc (Revision c45ce21dd8064576c8f6fef15b6c9292c903d43e) JENKINS-30705 Reset cache for exact results in unittest (Revision 7d260f317bb79c6e7f02b62f99a6819e8db26cfd) Result = UNSTABLE ogondza : 9bebf2101c00e8c41c60853849cb1b3361bf8444 Files : core/src/main/java/hudson/model/Label.java ogondza : c45ce21dd8064576c8f6fef15b6c9292c903d43e Files : core/src/main/java/hudson/model/Label.java ogondza : 7d260f317bb79c6e7f02b62f99a6819e8db26cfd Files : test/src/test/java/hudson/model/NodeTest.java

            People

              olivergondza Oliver Gondža
              olivergondza Oliver Gondža
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: