Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30751

TAP Test Results page shows TODO tests as failed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Component/s: tap-plugin
    • Labels:
      None
    • Environment:
      RHEL6, Java 1.8, TAP plugin 1.24
    • Similar Issues:

      Description

      Some of my jobs generates .tap files with TODO results. The Extended Test Results page for these jobs show these TODO tests correctly and the count of tests failed for the jobs are correct everywhere, but on the TAP Test Results pages (/tapTestReport/ URL) those TODO tests are incorrectly displayed in the "All Failed Tests" block.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          kinow Bruno P. Kinoshita added a comment -

          While I was working on another issue, related to SKIP TAP directive, I suspected a similar issue could be happening with TODO's (IOW, treating them as failed/success/skip/etc).

          Didn't try to reproduce it yet, but I have a hunch on where and how to fix it. Will try to include in the next development cycle.

          Thanks for reporting.
          Bruno

          Show
          kinow Bruno P. Kinoshita added a comment - While I was working on another issue, related to SKIP TAP directive, I suspected a similar issue could be happening with TODO's (IOW, treating them as failed/success/skip/etc). Didn't try to reproduce it yet, but I have a hunch on where and how to fix it. Will try to include in the next development cycle. Thanks for reporting. Bruno
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          TODO.txt
          src/main/java/org/tap4j/plugin/TapResult.java
          src/main/java/org/tap4j/plugin/model/TapTestResultResult.java
          src/main/java/org/tap4j/plugin/util/Util.java
          http://jenkins-ci.org/commit/tap-plugin/a1da20b92eb23fc15891041071a4e366206df10b
          Log:
          [FIXED JENKINS-30751] Use same logic everywhere to say whether a test is a failure or not

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: TODO.txt src/main/java/org/tap4j/plugin/TapResult.java src/main/java/org/tap4j/plugin/model/TapTestResultResult.java src/main/java/org/tap4j/plugin/util/Util.java http://jenkins-ci.org/commit/tap-plugin/a1da20b92eb23fc15891041071a4e366206df10b Log: [FIXED JENKINS-30751] Use same logic everywhere to say whether a test is a failure or not
          Hide
          Permalink
          kinow Bruno P. Kinoshita added a comment -

          We are now using the same code to choose whether it is a failure or not, and the behaviour should be more consistent (though it wasn't an elegant solution, as the code needs some refactoring).

          Thanks for reporting the issue!

          Show
          kinow Bruno P. Kinoshita added a comment - We are now using the same code to choose whether it is a failure or not, and the behaviour should be more consistent (though it wasn't an elegant solution, as the code needs some refactoring). Thanks for reporting the issue!
          Hide
          Permalink
          kinow Bruno P. Kinoshita added a comment -

          Closing off the taask

          Show
          kinow Bruno P. Kinoshita added a comment - Closing off the taask

            People

            Assignee:
            kinow Bruno P. Kinoshita
            Reporter:
            anjohnson Andrew Johnson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: