• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • regression from 1.630 -> 1.633

      as seen in the screenshots below, there is one good (the old version), and one bad (the new version). The build history table now shows an improper sorting, at least for jobs that had existing history with them during the upgrade process.

      Instead of showing the most recent builds at the top, oldest at the bottom, it now has a rather random looking sort to it

      this seems to be caused by the following PR: https://github.com/jenkinsci/jenkins/pull/1641

          [JENKINS-30899] Build History order not sorted properly

          No, I was using the official 1.633 release. Now I've tested Daniel's build as well:

          • It is showing the latest builds on the first page as expected.
          • Clicking on the "Older builds" does nothing—doesn't change to the older builds.
          • Clicking on the "Newer builds" switches to a blank list.

          Anatolijs Tarasovs added a comment - No, I was using the official 1.633 release. Now I've tested Daniel's build as well: It is showing the latest builds on the first page as expected. Clicking on the "Older builds" does nothing—doesn't change to the older builds. Clicking on the "Newer builds" switches to a blank list.

          Tom FENNELLY added a comment -

          Hi atarasovs, ycollet, twilek, tcollege jvallet etc ... would you mind trying the build at https://jenkins.ci.cloudbees.com/job/core/job/jenkins-core/3363/

          We hope it contains fixes for the issues you are seeing. Would be great if you could try it out and let us know.

          Tom FENNELLY added a comment - Hi atarasovs , ycollet , twilek , tcollege jvallet etc ... would you mind trying the build at https://jenkins.ci.cloudbees.com/job/core/job/jenkins-core/3363/ We hope it contains fixes for the issues you are seeing. Would be great if you could try it out and let us know.

          Hi Tom Fennelly,

          I just testet the mentioned build from https://jenkins.ci.cloudbees.com/job/core/job/jenkins-core/3363/.
          It seems to fix the bug 30899.

          The build are shown in an order as expected.
          "Older builds" shows the "next page" correctly.
          "Newer builds" shows the same order as expected.

          Thanks for the fast reaction...

          Andreas Esterle added a comment - Hi Tom Fennelly, I just testet the mentioned build from https://jenkins.ci.cloudbees.com/job/core/job/jenkins-core/3363/ . It seems to fix the bug 30899. The build are shown in an order as expected. "Older builds" shows the "next page" correctly. "Newer builds" shows the same order as expected. Thanks for the fast reaction...

          Tom FENNELLY added a comment -

          nde Thanks for letting us know Andreas. Hopefully we'll get more positives and then we can push the fix.

          Tom FENNELLY added a comment - nde Thanks for letting us know Andreas. Hopefully we'll get more positives and then we can push the fix.

          Shaun Reich added a comment -

          tfennelly confirmed, it works as expected/previously, now.

          Shaun Reich added a comment - tfennelly confirmed, it works as expected/previously, now.

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/jenkins/widgets/HistoryPageEntry.java
          http://jenkins-ci.org/commit/jenkins/7410a593b30d635010c6344a812889074e68ac98
          Log:
          [FIX JENKINS-30899] Do not rely on Run.queueId for builds widget

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/widgets/HistoryPageEntry.java http://jenkins-ci.org/commit/jenkins/7410a593b30d635010c6344a812889074e68ac98 Log: [FIX JENKINS-30899] Do not rely on Run.queueId for builds widget

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/jenkins/widgets/HistoryPageEntry.java
          core/src/main/java/jenkins/widgets/HistoryPageFilter.java
          core/src/test/java/jenkins/widgets/HistoryPageFilterTest.java
          war/images/go-down.svg
          war/images/go-top.svg
          war/images/go-up.svg
          war/src/main/webapp/css/style.css
          war/src/main/webapp/images/16x16/bullseye.png
          war/src/main/webapp/images/16x16/go_down.png
          war/src/main/webapp/images/16x16/go_top.png
          war/src/main/webapp/images/16x16/go_up.png
          war/src/main/webapp/scripts/hudson-behavior.js
          http://jenkins-ci.org/commit/jenkins/2dd658d6fc9a085ea5bd1e8a4e7c178cd95e2f86
          Log:
          Merge pull request #1872 from tfennelly/bh-pagination-daniel

          [FIX JENKINS-30899] Build History Pagination/Search fixes

          Compare: https://github.com/jenkinsci/jenkins/compare/6aba76dcb00f...2dd658d6fc9a

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/widgets/HistoryPageEntry.java core/src/main/java/jenkins/widgets/HistoryPageFilter.java core/src/test/java/jenkins/widgets/HistoryPageFilterTest.java war/images/go-down.svg war/images/go-top.svg war/images/go-up.svg war/src/main/webapp/css/style.css war/src/main/webapp/images/16x16/bullseye.png war/src/main/webapp/images/16x16/go_down.png war/src/main/webapp/images/16x16/go_top.png war/src/main/webapp/images/16x16/go_up.png war/src/main/webapp/scripts/hudson-behavior.js http://jenkins-ci.org/commit/jenkins/2dd658d6fc9a085ea5bd1e8a4e7c178cd95e2f86 Log: Merge pull request #1872 from tfennelly/bh-pagination-daniel [FIX JENKINS-30899] Build History Pagination/Search fixes Compare: https://github.com/jenkinsci/jenkins/compare/6aba76dcb00f...2dd658d6fc9a

          Daniel Beck added a comment -

          Merged towards 1.634 which is scheduled for release early next week.

          (Note that 1.633 introduced another issue whose fixes have not yet been merged – JENKINS-30820 and all the duplicates linked there)

          Daniel Beck added a comment - Merged towards 1.634 which is scheduled for release early next week. (Note that 1.633 introduced another issue whose fixes have not yet been merged – JENKINS-30820 and all the duplicates linked there)

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4323
          [FIX JENKINS-30899] Do not rely on Run.queueId for builds widget (Revision 7410a593b30d635010c6344a812889074e68ac98)

          Result = SUCCESS
          tom.fennelly : 7410a593b30d635010c6344a812889074e68ac98
          Files :

          • core/src/main/java/jenkins/widgets/HistoryPageEntry.java

          dogfood added a comment - Integrated in jenkins_main_trunk #4323 [FIX JENKINS-30899] Do not rely on Run.queueId for builds widget (Revision 7410a593b30d635010c6344a812889074e68ac98) Result = SUCCESS tom.fennelly : 7410a593b30d635010c6344a812889074e68ac98 Files : core/src/main/java/jenkins/widgets/HistoryPageEntry.java

          Jay Beeckman added a comment -

          This fix has worked for us.

          Jay Beeckman added a comment - This fix has worked for us.

            tfennelly Tom FENNELLY
            sreich Shaun Reich
            Votes:
            29 Vote for this issue
            Watchers:
            35 Start watching this issue

              Created:
              Updated:
              Resolved: