Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31098

New delete-node CLI command breaks node cleanup in cloud plugins

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • cli, core
    • Jenkins 1.625.1 LTS

      The new implementation of the delete-node command badly breaks cleanup of cloud-managed VMs (at least in jclouds-plugin and openstack-plugin)

      The cloud plugins extend AbstractCloudComputer and then override doDoDelete() in order to perform any cleanup (and delay the actual deleteion until this is done). The new delete-node command does not invoke this and thus when using this command, lots of unused VM's are kept around which get never cleaned up. In fact, there is no "hook" whatsoever anymore which allows a cloud plugin to intercept node deletion.

      If there's some other (new) functionality to intercept node-deletion please let me know.
      Unfortunately this made it into 1.625.1 LTS and I only noticed that change now. It is not even mentioned in the changelog.

          [JENKINS-31098] New delete-node CLI command breaks node cleanup in cloud plugins

          Fritz Elfert created issue -
          Pavel Janoušek made changes -
          Assignee New: Pavel Janoušek [ pajasoft ]
          Pavel Janoušek made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Oliver Gondža made changes -
          Labels New: lts-candidate
          Oliver Gondža made changes -
          Labels Original: lts-candidate New: 1.625.3-fixed
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 166269 ] New: JNJira + In-Review [ 197962 ]

            pajasoft Pavel Janoušek
            felfert Fritz Elfert
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: