Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31098

New delete-node CLI command breaks node cleanup in cloud plugins

    XMLWordPrintable

Details

    Description

      The new implementation of the delete-node command badly breaks cleanup of cloud-managed VMs (at least in jclouds-plugin and openstack-plugin)

      The cloud plugins extend AbstractCloudComputer and then override doDoDelete() in order to perform any cleanup (and delay the actual deleteion until this is done). The new delete-node command does not invoke this and thus when using this command, lots of unused VM's are kept around which get never cleaned up. In fact, there is no "hook" whatsoever anymore which allows a cloud plugin to intercept node deletion.

      If there's some other (new) functionality to intercept node-deletion please let me know.
      Unfortunately this made it into 1.625.1 LTS and I only noticed that change now. It is not even mentioned in the changelog.

      Attachments

        Activity

          felfert Fritz Elfert created issue -
          pajasoft Pavel Janoušek made changes -
          Field Original Value New Value
          Assignee Pavel Janoušek [ pajasoft ]
          pajasoft Pavel Janoušek made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          olivergondza Oliver Gondža made changes -
          Labels lts-candidate
          olivergondza Oliver Gondža made changes -
          Labels lts-candidate 1.625.3-fixed
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 166269 ] JNJira + In-Review [ 197962 ]

          People

            pajasoft Pavel Janoušek
            felfert Fritz Elfert
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: