Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31161

Update HTMLUnit in Jenkins Core

    XMLWordPrintable

Details

    • Story
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • core

    Description

      It is hoped to use modern JS libs for all of our new UI work (create item, 1st run plugin bundling experience etc). Jenkins Core currently uses old JS libs, mainly prototypejs. This library has been dead for years + we are using a forked version of it. We were hoping to get away from it in the newer work.
      We are also currently using a forked version of HtmlUnit in Jenkins Core. It's an old version (2.6 - latest is 2.18). This version of HtmlUnit doesn't support use of jQuery (and probably lots of other JS libs we would want to use) e.g. it complains about how the "isArray" method is defined in the lib. They claim that the latest version of HtmlUnit "fully supports" jQuery (I'm not convinced).
      The problem for us is that the Jenkins Core test harness relies heavily on HtmlUnit. There are many many tests written to run against the forked version, which means they fail when we try to do anything that that version of HtmlUnit doesn't like e.g. introduce jQuery.

      Attachments

        Issue Links

          Activity

            hrmpw Patrick Wolf created issue -
            hrmpw Patrick Wolf made changes -
            Field Original Value New Value
            Epic Link JENKINS-31156 [ 165812 ]
            hrmpw Patrick Wolf made changes -
            Link This issue is related to JENKINS-30488 [ JENKINS-30488 ]
            jglick Jesse Glick made changes -
            Assignee Tom FENNELLY [ tfennelly ]
            jglick Jesse Glick added a comment -

            I think this was fixed a while ago?

            jglick Jesse Glick added a comment - I think this was fixed a while ago?
            jglick Jesse Glick made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            tfennelly Tom FENNELLY added a comment -

            It was. Thanks for closing.

            tfennelly Tom FENNELLY added a comment - It was. Thanks for closing.

            Code changed in jenkins
            User: recena
            Path:
            core/src/main/java/hudson/model/ItemGroupMixIn.java
            core/src/main/java/jenkins/model/item_category/ItemCategoryConfigurator.java
            http://jenkins-ci.org/commit/jenkins/2d0219f739030a45f7fce645b4e4e02ac7536574
            Log:
            Merge branch 'JENKINS-31162' into JENKINS-31161-withUI

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: core/src/main/java/hudson/model/ItemGroupMixIn.java core/src/main/java/jenkins/model/item_category/ItemCategoryConfigurator.java http://jenkins-ci.org/commit/jenkins/2d0219f739030a45f7fce645b4e4e02ac7536574 Log: Merge branch ' JENKINS-31162 ' into JENKINS-31161 -withUI

            Code changed in jenkins
            User: Manuel Recena
            Path:
            core/src/main/java/hudson/model/ItemGroupMixIn.java
            core/src/main/java/jenkins/model/item_category/Category.java
            core/src/main/java/jenkins/model/item_category/ItemCategory.java
            core/src/main/java/jenkins/model/item_category/ItemCategoryConfigurator.java
            http://jenkins-ci.org/commit/jenkins/480e41a356a584262881b99acfd0e3d8d316a12d
            Log:
            Merge remote-tracking branch 'origin/JENKINS-31162' into JENKINS-31161-withUI

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: core/src/main/java/hudson/model/ItemGroupMixIn.java core/src/main/java/jenkins/model/item_category/Category.java core/src/main/java/jenkins/model/item_category/ItemCategory.java core/src/main/java/jenkins/model/item_category/ItemCategoryConfigurator.java http://jenkins-ci.org/commit/jenkins/480e41a356a584262881b99acfd0e3d8d316a12d Log: Merge remote-tracking branch 'origin/ JENKINS-31162 ' into JENKINS-31161 -withUI
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 166342 ] JNJira + In-Review [ 197982 ]

            People

              tfennelly Tom FENNELLY
              hrmpw Patrick Wolf
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: