Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31318

Retry button invisible with "Build" project role

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • naginator-plugin
    • None

      When used together with the Role Strategy Plugin, Naginator doesn't show the "Retry" button to users with a project role giving them the "Job/Build" permission.

      It works, however, if the "Job/Build" permission is set at the global level.

      It's also worth mentioning that the Build action itself actually works, only Naginator's Retry feature is affected.

          [JENKINS-31318] Retry button invisible with "Build" project role

          ikedam added a comment - - edited

          Naginator looks check only the global permission, not a permission for that project.
          It's an issue only for role-strategy, also for any strategies defining permissions for projects (such as [matrix-authhttps://wiki.jenkins-ci.org/display/JENKINS/Matrix+Authorization+Strategy+Plugin]).

          Scheduled for the next release (1.16.1 or 1.17)

          ikedam added a comment - - edited Naginator looks check only the global permission, not a permission for that project. It's an issue only for role-strategy, also for any strategies defining permissions for projects (such as [matrix-authhttps://wiki.jenkins-ci.org/display/JENKINS/Matrix+Authorization+Strategy+Plugin] ). Scheduled for the next release (1.16.1 or 1.17)

          ikedam added a comment -

          https://github.com/jenkinsci/naginator-plugin/pull/22

          ikedam added a comment - https://github.com/jenkinsci/naginator-plugin/pull/22

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/test/java/com/chikli/hudson/plugin/naginator/NaginatorActionFactoryTest.java
          http://jenkins-ci.org/commit/naginator-plugin/9d3e5bbccbec13e50089c8312e9b329f2cb9e1ed
          Log:
          JENKINS-31318 Added tests for NaginatorActionFactory including a test reproducing JENKINS-31318, doesn't check for permissions for each projects.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/test/java/com/chikli/hudson/plugin/naginator/NaginatorActionFactoryTest.java http://jenkins-ci.org/commit/naginator-plugin/9d3e5bbccbec13e50089c8312e9b329f2cb9e1ed Log: JENKINS-31318 Added tests for NaginatorActionFactory including a test reproducing JENKINS-31318 , doesn't check for permissions for each projects.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorRetryAction.java
          http://jenkins-ci.org/commit/naginator-plugin/91d88d911038f3866829f711ae8f1bb3e3aa672c
          Log:
          [FIXED JENKINS-31318] Check BUILD permissions not for Jenkins but for each projects.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/com/chikli/hudson/plugin/naginator/NaginatorRetryAction.java http://jenkins-ci.org/commit/naginator-plugin/91d88d911038f3866829f711ae8f1bb3e3aa672c Log: [FIXED JENKINS-31318] Check BUILD permissions not for Jenkins but for each projects.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/com/chikli/hudson/plugin/naginator/NaginatorRetryAction.java
          src/test/java/com/chikli/hudson/plugin/naginator/NaginatorActionFactoryTest.java
          http://jenkins-ci.org/commit/naginator-plugin/888e8f4bb8081edc990be3c790cb17d9e6c69cde
          Log:
          Merge pull request #22 from ikedam/feature/JENKINS-31318_UserPermission

          JENKINS-31318 Retry button invisible with "Build" project role

          Compare: https://github.com/jenkinsci/naginator-plugin/compare/d46742e5c2d5...888e8f4bb808

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/com/chikli/hudson/plugin/naginator/NaginatorRetryAction.java src/test/java/com/chikli/hudson/plugin/naginator/NaginatorActionFactoryTest.java http://jenkins-ci.org/commit/naginator-plugin/888e8f4bb8081edc990be3c790cb17d9e6c69cde Log: Merge pull request #22 from ikedam/feature/ JENKINS-31318 _UserPermission JENKINS-31318 Retry button invisible with "Build" project role Compare: https://github.com/jenkinsci/naginator-plugin/compare/d46742e5c2d5...888e8f4bb808

          ikedam added a comment -

          Fixed in 1.16.1.
          It will be available in the update center in a day.

          ikedam added a comment - Fixed in 1.16.1. It will be available in the update center in a day.

            ikedam ikedam
            antoineco Antoine Cotten
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: