Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31320

Promotion Status shows an excess of whitespace

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • promoted-builds-plugin
    • Jenkins 1.625.1, promoted-builds-plugin 2.2.3

      We recently upgraded from Jenkins 1.609.3 to 1.625.1 and from promoted-builds 2.2.2 to 2.2.3. We're now seeing a weird excess of whitespace on each Promotion Status page; the first div in the 'main-panel' div has a really long length - over 2000px - even if the promotion process being described has never had any promotions.

      The amount of extra whitespace seems to grow with every promotion.

      I've tried downgrading to 2.2.2 and see the same behavior. Not sure if this is something w/ the plugin or Jenkins itself; I haven't tried downgrading Jenkins to 1.609.3.

      See attached pictures.

        1. longimage.png
          longimage.png
          262 kB
        2. promoted-firebug.png
          promoted-firebug.png
          104 kB

          [JENKINS-31320] Promotion Status shows an excess of whitespace

          Manuel Recena Soto added a comment -

          jurgens00, I'm working on it.

          Manuel Recena Soto added a comment - jurgens00 , I'm working on it.

          Manuel Recena Soto added a comment -

          A PR has been added /cc jurgens00 oleg_nenashev

          Manuel Recena Soto added a comment - A PR has been added /cc jurgens00 oleg_nenashev

          jurgezero added a comment - - edited

          Great, I am looking forward to the fix. Thank you!

          jurgezero added a comment - - edited Great, I am looking forward to the fix. Thank you!

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/resources/hudson/plugins/promoted_builds/PromotedProjectAction/index.jelly
          src/main/webapp/css/promoted-builds.css
          http://jenkins-ci.org/commit/promoted-builds-plugin/948d258a7ca2737d621120a4dc41253a770383b4
          Log:
          JENKINS-31320 Layout broken as of 1.619+

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/resources/hudson/plugins/promoted_builds/PromotedProjectAction/index.jelly src/main/webapp/css/promoted-builds.css http://jenkins-ci.org/commit/promoted-builds-plugin/948d258a7ca2737d621120a4dc41253a770383b4 Log: JENKINS-31320 Layout broken as of 1.619+

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/resources/hudson/plugins/promoted_builds/PromotedProjectAction/index.jelly
          src/main/webapp/css/promoted-builds.css
          http://jenkins-ci.org/commit/promoted-builds-plugin/834723e38b0b854507b2a37c6b9738e0782adfef
          Log:
          Merge pull request #69 from recena/master

          JENKINS-31320 Layout broken as of 1.619+

          Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/4223721be5fa...834723e38b0b

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/resources/hudson/plugins/promoted_builds/PromotedProjectAction/index.jelly src/main/webapp/css/promoted-builds.css http://jenkins-ci.org/commit/promoted-builds-plugin/834723e38b0b854507b2a37c6b9738e0782adfef Log: Merge pull request #69 from recena/master JENKINS-31320 Layout broken as of 1.619+ Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/4223721be5fa...834723e38b0b

          Oleg Nenashev added a comment -

          The fix has been released as 2.23.1

          Oleg Nenashev added a comment - The fix has been released as 2.23.1

          Manuel Recena Soto added a comment -

          oleg_nenashev, Great! This is real open source and collaboration!

          Manuel Recena Soto added a comment - oleg_nenashev , Great! This is real open source and collaboration!

          Oleg Nenashev added a comment -

          Yep, it works especially well if you do it after the midnight
          Thanks for fixing this issue!

          Oleg Nenashev added a comment - Yep, it works especially well if you do it after the midnight Thanks for fixing this issue!

          Manuel Recena Soto added a comment -

          jurgens00, It would be nice you can confirm that the new release works fine with your data and configuration.

          Manuel Recena Soto added a comment - jurgens00 , It would be nice you can confirm that the new release works fine with your data and configuration.

          Will Saxon added a comment -

          I can confirm that it works in mine. Thanks everyone.

          Will Saxon added a comment - I can confirm that it works in mine. Thanks everyone.

            recena Manuel Recena Soto
            wsaxon Will Saxon
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: