Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31344

Allow users to clear out individual approved signatures from the UI

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Duplicate
    • Icon: Major Major
    • script-security-plugin
    • workflow-1.10.1
      FreeBSD 10.2
      Jenkins 1.635
      OpenJDK 1.8.0_60-b24

      Larger installations may have a lot of approved signatures and the current UI only allows one to clear all signatures with a "Clear Approvals" button (see screen shot below). It would be nice if the UI would allow one to clear individual signatures. A base example would be if the user accidentally approved System.exit but does not want that to run!

      This seems like a matter of reversing the way things are hashed in the below code and adding it as a new function that is called by a button from the UI?

      https://github.com/jenkinsci/script-security-plugin/blob/master/src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java

        1. Unapprove.PNG
          Unapprove.PNG
          32 kB

          [JENKINS-31344] Allow users to clear out individual approved signatures from the UI

          Jesse Glick added a comment -

          Probably the button to clear everything should be removed, the textarea should be made into a multiselect list control, and there should be a button to remove selected items. Or with a little more work we could have a fancier UI with a little × button next to each item.

          Jesse Glick added a comment - Probably the button to clear everything should be removed, the textarea should be made into a multiselect list control, and there should be a button to remove selected items. Or with a little more work we could have a fancier UI with a little × button next to each item.

            jglick Jesse Glick
            ganthore Mark Austin
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: