Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31615

Sometimes the plugin leaves behind a stale PID file or zombie Sauce Connect process, should the plugin handle this?

    XMLWordPrintable

Details

    Description

      If Sauce Connect fails to close properly (for whatever reason), should the plugin force close the process and clean up it's pidfile? I am inclined to say that it should but am not aware of what limitations or issues making such a change would cause.

      Attachments

        Activity

          halkeye Gavin Mogan added a comment -

          okay cool, we'll look into it.

          i suspect once you finish upgrading to the jenkins plugin this will be delt with.

          halkeye Gavin Mogan added a comment - okay cool, we'll look into it. i suspect once you finish upgrading to the jenkins plugin this will be delt with.

          I upgraded to 1.145 but I get below error. Not sure what to do here

          Starting pre-build for Sauce Labs plugin
          Starting Sauce Connect on master node using identifier: testCaPadSuite-1473696246755
          Launching Sauce Connect on sm1-jenkins3-1-sfm.eng.sfdc.net
          Error launching Sauce Connect
          Flushing Sauce Connect Input Stream
          Flushing Sauce Connect Error Stream
          Closing Sauce Connect process
          FATAL: Error launching Sauce Connect
          com.saucelabs.ci.sauceconnect.AbstractSauceTunnelManager$SauceConnectDidNotStartException: Error launching Sauce Connect
          at com.saucelabs.ci.sauceconnect.AbstractSauceTunnelManager.openConnection(AbstractSauceTunnelManager.java:320)
          at hudson.plugins.sauce_ondemand.SauceOnDemandBuildWrapper$SauceConnectHandler.call(SauceOnDemandBuildWrapper.java:916)
          at hudson.plugins.sauce_ondemand.SauceOnDemandBuildWrapper.setUp(SauceOnDemandBuildWrapper.java:347)
          at hudson.model.Build$BuildExecution.doRun(Build.java:156)
          at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:537)
          at hudson.model.Run.execute(Run.java:1744)
          at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
          at hudson.model.ResourceController.execute(ResourceController.java:98)
          at hudson.model.Executor.run(Executor.java:374)
          An attempt to send an e-mail to empty list of recipients, ignored.
          Finished: FAILURE

          suprinder Suprinder Pujji added a comment - I upgraded to 1.145 but I get below error. Not sure what to do here Starting pre-build for Sauce Labs plugin Starting Sauce Connect on master node using identifier: testCaPadSuite-1473696246755 Launching Sauce Connect on sm1-jenkins3-1-sfm.eng.sfdc.net Error launching Sauce Connect Flushing Sauce Connect Input Stream Flushing Sauce Connect Error Stream Closing Sauce Connect process FATAL: Error launching Sauce Connect com.saucelabs.ci.sauceconnect.AbstractSauceTunnelManager$SauceConnectDidNotStartException: Error launching Sauce Connect at com.saucelabs.ci.sauceconnect.AbstractSauceTunnelManager.openConnection(AbstractSauceTunnelManager.java:320) at hudson.plugins.sauce_ondemand.SauceOnDemandBuildWrapper$SauceConnectHandler.call(SauceOnDemandBuildWrapper.java:916) at hudson.plugins.sauce_ondemand.SauceOnDemandBuildWrapper.setUp(SauceOnDemandBuildWrapper.java:347) at hudson.model.Build$BuildExecution.doRun(Build.java:156) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:537) at hudson.model.Run.execute(Run.java:1744) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:374) An attempt to send an e-mail to empty list of recipients, ignored. Finished: FAILURE
          halkeye Gavin Mogan added a comment -

          I'm mobile today and at a conference all week, so you'll have quicker support opening a saucelabs support ticket.

          I believe our latest version is 1.155

          In Addition, does your log say anything? All that stacktrace says is it had trouble starting up

          halkeye Gavin Mogan added a comment - I'm mobile today and at a conference all week, so you'll have quicker support opening a saucelabs support ticket. I believe our latest version is 1.155 In Addition, does your log say anything? All that stacktrace says is it had trouble starting up

          suprinder the error you are seeing is not related to pid file locking. If it were, you would see the following in the logs as the error code for a PID file collision is rather explicit.

          12 Sep 12:28:33 - Sauce Connect 4.3.16, build 2399 c7e5fec
          12 Sep 12:28:33 - can't lock pidfile currentA. Please check if Sauce Connect is already running.
          12 Sep 12:28:33 - Error creating pidfile currentA.
          

          So no, the bug here is unrelated to the issue you are facing and I would advice contact Sauce Labs support as halkeye suggested. From the logs you look to be having a connectivity issue of some kind.

          thecampbellcash Andrew Campbell added a comment - suprinder the error you are seeing is not related to pid file locking. If it were, you would see the following in the logs as the error code for a PID file collision is rather explicit. 12 Sep 12:28:33 - Sauce Connect 4.3.16, build 2399 c7e5fec 12 Sep 12:28:33 - can't lock pidfile currentA. Please check if Sauce Connect is already running. 12 Sep 12:28:33 - Error creating pidfile currentA. So no, the bug here is unrelated to the issue you are facing and I would advice contact Sauce Labs support as halkeye suggested. From the logs you look to be having a connectivity issue of some kind.

          Sure Andrew/Gavin. Thanks for your prompt replies.

          suprinder Suprinder Pujji added a comment - Sure Andrew/Gavin. Thanks for your prompt replies.

          People

            yfangsl Yeh Fang
            thecampbellcash Andrew Campbell
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated: