Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31631

JenkinsRule.submit should click YUI submit button

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      JenkinsRule.submit was calling HtmlFormUtil.submit for YUI submit <button> elements, which resulted in a submit on the form because <button> elements are implemented as Submittable in HtmlUnit.

      It should instead be doing a click on the YUI <button>.

          [JENKINS-31631] JenkinsRule.submit should click YUI submit button

          Tom FENNELLY added a comment -

          PR: https://github.com/jenkinsci/jenkins/pull/1918

          Tom FENNELLY added a comment - PR: https://github.com/jenkinsci/jenkins/pull/1918

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Tom Fennelly
          Path:
          test/pom.xml
          test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins/23276180209b40315d19ea1c143b69d348d607ae
          Log:
          Merge pull request #1918 from tfennelly/htmlunit-fixes

          [Fixed JENKINS-31631] Handle YUI submit <button> clicks

          Compare: https://github.com/jenkinsci/jenkins/compare/d00dc71b24db...23276180209b

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Fennelly Path: test/pom.xml test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins/23276180209b40315d19ea1c143b69d348d607ae Log: Merge pull request #1918 from tfennelly/htmlunit-fixes [Fixed JENKINS-31631] Handle YUI submit <button> clicks Compare: https://github.com/jenkinsci/jenkins/compare/d00dc71b24db...23276180209b

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: tfennelly
          Path:
          test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins/5defc349a8894bbc6dd524e6f9ba9c1fc5662e52
          Log:
          JENKINS-31631 Handle YUI submit <button> clicks

          (cherry picked from commit 7fdb589133de09e77d29397ee01bcc9004e25cb2)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins/5defc349a8894bbc6dd524e6f9ba9c1fc5662e52 Log: JENKINS-31631 Handle YUI submit <button> clicks (cherry picked from commit 7fdb589133de09e77d29397ee01bcc9004e25cb2)

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: tfennelly
          Path:
          test/pom.xml
          http://jenkins-ci.org/commit/jenkins/0056b55146cb1948e3a828a905f543a1c540ab22
          Log:
          JENKINS-31631 Exclude transitive htmlunit-core-js via embedded-rhino-debugger

          (cherry picked from commit aec2d8afb1391b479e2531c0d49c211f81aba8b3)

          Compare: https://github.com/jenkinsci/jenkins/compare/b66128c31744...0056b55146cb

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: test/pom.xml http://jenkins-ci.org/commit/jenkins/0056b55146cb1948e3a828a905f543a1c540ab22 Log: JENKINS-31631 Exclude transitive htmlunit-core-js via embedded-rhino-debugger (cherry picked from commit aec2d8afb1391b479e2531c0d49c211f81aba8b3) Compare: https://github.com/jenkinsci/jenkins/compare/b66128c31744...0056b55146cb

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4373
          JENKINS-31631 Handle YUI submit <button> clicks (Revision 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52)
          JENKINS-31631 Exclude transitive htmlunit-core-js via embedded-rhino-debugger (Revision 0056b55146cb1948e3a828a905f543a1c540ab22)

          Result = SUCCESS
          ogondza : 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52
          Files :

          • test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          • test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java

          ogondza : 0056b55146cb1948e3a828a905f543a1c540ab22
          Files :

          • test/pom.xml

          dogfood added a comment - Integrated in jenkins_main_trunk #4373 JENKINS-31631 Handle YUI submit <button> clicks (Revision 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52) JENKINS-31631 Exclude transitive htmlunit-core-js via embedded-rhino-debugger (Revision 0056b55146cb1948e3a828a905f543a1c540ab22) Result = SUCCESS ogondza : 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52 Files : test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java ogondza : 0056b55146cb1948e3a828a905f543a1c540ab22 Files : test/pom.xml

          dogfood added a comment -

          Integrated in jenkins_2.0 #5
          JENKINS-31631 Handle YUI submit <button> clicks (Revision 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52)
          JENKINS-31631 Exclude transitive htmlunit-core-js via (Revision 0056b55146cb1948e3a828a905f543a1c540ab22)

          Result = SUCCESS
          ogondza : 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52
          Files :

          • test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          • test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java

          ogondza : 0056b55146cb1948e3a828a905f543a1c540ab22
          Files :

          • test/pom.xml

          dogfood added a comment - Integrated in jenkins_2.0 #5 JENKINS-31631 Handle YUI submit <button> clicks (Revision 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52) JENKINS-31631 Exclude transitive htmlunit-core-js via (Revision 0056b55146cb1948e3a828a905f543a1c540ab22) Result = SUCCESS ogondza : 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52 Files : test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java ogondza : 0056b55146cb1948e3a828a905f543a1c540ab22 Files : test/pom.xml

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: tfennelly
          Path:
          test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins-test-harness/bd76ca4d585295ca2395ed14868a7d7423932d44
          Log:
          JENKINS-31631 Handle YUI submit <button> clicks

          (cherry picked from commit 7fdb589133de09e77d29397ee01bcc9004e25cb2)

          Originally-Committed-As: 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins-test-harness/bd76ca4d585295ca2395ed14868a7d7423932d44 Log: JENKINS-31631 Handle YUI submit <button> clicks (cherry picked from commit 7fdb589133de09e77d29397ee01bcc9004e25cb2) Originally-Committed-As: 5defc349a8894bbc6dd524e6f9ba9c1fc5662e52

            tfennelly Tom FENNELLY
            tfennelly Tom FENNELLY
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: