Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31661

Jenkins.rootUrl too often unset or incorrect

    XMLWordPrintable

Details

    Description

      Jenkins URL field is showing a value even not being set (it is actually unset in config.xml). This behaviour is confusing for users (it seems to be set, but it's not).

      One things to improve it:

      1. Don't set the value in the field, but suggest it (form validation)
      2. Add an administrative monitor pointing to it

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-60750 Setup wizard asks to set root URL even when already set if admin user creation skipped

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-51660 Setup wizard suggests root URL not ending in slash

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-51816 'Instance Configuration' step displays request result

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is blocking

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-33508 Don't offer Bitbucket Team Source Repo webhook configuration while Jenkins URL is unconfigured

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-28466 Can't use environment variables like JENKINS_URL、JOB_URL、BUILD_URL in a new jenkins before it's save-button which is in system settings is clicked

          • Major - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-32192 Hyperlinks quietly fail when JenkinsLocationConfiguration incorrect

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-51064 Lenient URL validator for Root URL

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-47426 ClientAuthenticationCache#getPropertyKey not consistent when rootUrl is not set

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link #3082

          Activity

            Ascending order - Click to sort in descending order
            View 12 older comments
            wfollonier Wadeck Follonier added a comment -

            ok2332 you're totally right, it was not the expected behavior concerning the TLD, I explicitely added the "_" case for internal hostname but not thought about the custom TLDs.

            wfollonier Wadeck Follonier added a comment - ok2332 you're totally right, it was not the expected behavior concerning the TLD, I explicitely added the "_" case for internal hostname but not thought about the custom TLDs.
            wfollonier Wadeck Follonier added a comment - - edited

            pmilliken ok2332 FYI I created a PR#3415 to address your concern. Feel free to test / review it.

            Also filed a separate issue : JENKINS-51064

            And a PR#3416 for adding the direct "Dismiss" button in this monitor message.

            wfollonier Wadeck Follonier added a comment - - edited pmilliken ok2332 FYI I created a PR#3415 to address your concern. Feel free to test / review it. Also filed a separate issue : JENKINS-51064 And a PR#3416 for adding the direct "Dismiss" button in this monitor message.
            danielbeck Daniel Beck added a comment -

            wfollonier I wonder whether you could just consider rootUrlFromRequest for the admin monitor – if that's the same as is configured, it can't be too wrong. WDYT?

            danielbeck Daniel Beck added a comment - wfollonier I wonder whether you could just consider rootUrlFromRequest for the admin monitor – if that's the same as is configured, it can't be too wrong. WDYT?
            pmilliken Paul Milliken added a comment - - edited

            wfollonier That sounds promising. I'm not set up to be able to test it readily at the moment unfortunately. My Jenkins URL is http://jenkins.XXXX.private/ - hopefully the relaxation of the TLD validation will permit that (from a quick read of the code, I think it will). For the time being, I've disabled the admin monitor on my installation.

            Thanks for the quick response.

            pmilliken Paul Milliken added a comment - - edited wfollonier That sounds promising. I'm not set up to be able to test it readily at the moment unfortunately. My Jenkins URL is http://jenkins.XXXX.private/  - hopefully the relaxation of the TLD validation will permit that (from a quick read of the code, I think it will). For the time being, I've disabled the admin monitor on my installation. Thanks for the quick response.
            oleg_nenashev Oleg Nenashev added a comment -

            Hit it on my instance as well. Will link the ticket to JENKINS-51064 properly

            oleg_nenashev Oleg Nenashev added a comment - Hit it on my instance as well. Will link the ticket to JENKINS-51064 properly

            People

              wfollonier Wadeck Follonier
              amuniz Antonio Muñiz
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: