• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      Jenkins URL field is showing a value even not being set (it is actually unset in config.xml). This behaviour is confusing for users (it seems to be set, but it's not).

      One things to improve it:

      1. Don't set the value in the field, but suggest it (form validation)
      2. Add an administrative monitor pointing to it

          [JENKINS-31661] Jenkins.rootUrl too often unset or incorrect

          Antonio Muñiz created issue -
          Jesse Glick made changes -
          Labels New: ux

          Jesse Glick added a comment -

          Cf. JenkinsLocationConfiguration. I also recommend caching the last-inferred URL on every page load (Functions.initPageVariables) so that Jenkins.getRootUrl would normally be non-null even outside a request even if the admin has not set it. Otherwise change #1 will cause even fewer installations to have a root URL set.

          Jesse Glick added a comment - Cf. JenkinsLocationConfiguration . I also recommend caching the last-inferred URL on every page load ( Functions.initPageVariables ) so that Jenkins.getRootUrl would normally be non-null even outside a request even if the admin has not set it. Otherwise change #1 will cause even fewer installations to have a root URL set.
          Jesse Glick made changes -
          Summary Original: Jenkins URL field showing a value that is not really set New: Jenkins.rootUrl too often unset or incorrect

          Antonio Muñiz added a comment - https://github.com/jenkinsci/jenkins/pull/1921
          Manuel Recena Soto made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]

          Jesse Glick added a comment -

          As of 2.0 I think we agreed that this should be set by the setup wizard, which should be both simpler than previously proposed approaches, and safer. I would recommend explicitly showing the guessed URL in an editable text field so that the user can correct this in the case of a reverse proxy. We can also get rid of the warning about use of localhost: if that is what you have picked, so be it.

          Jesse Glick added a comment - As of 2.0 I think we agreed that this should be set by the setup wizard, which should be both simpler than previously proposed approaches, and safer. I would recommend explicitly showing the guessed URL in an editable text field so that the user can correct this in the case of a reverse proxy. We can also get rid of the warning about use of localhost : if that is what you have picked, so be it.

          Manuel Recena Soto added a comment - jglick

          Yeah, agreed.

          Antonio Muñiz added a comment - Yeah, agreed.

            wfollonier Wadeck Follonier
            amuniz Antonio Muñiz
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: