Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31753

Fields are aligned at the bottom in the view of the parameters of a job

      An error is present in the view of the parameters of a job. Fields are aligned at the bottom.
      This error is present on the version 1.638 and LTS version 1.625.2.

        1. bug_view_parameter.jpg
          bug_view_parameter.jpg
          56 kB
        2. index.jelly
          2 kB
        3. pane.jelly
          3 kB
        4. Paramètres [Jenkins] - 1.638.jpg
          Paramètres [Jenkins] - 1.638.jpg
          79 kB
        5. resultat-patch.jpg
          resultat-patch.jpg
          69 kB
        6. view parameter.jpg
          view parameter.jpg
          79 kB

          [JENKINS-31753] Fields are aligned at the bottom in the view of the parameters of a job

          Daniel Beck added a comment -

          Not sure this change is correct. Another possibility could be the div tag directly inside j:choose. I'll investigate this. My preferred solution to this particular page is to just get rid of the element anyway, as it's specifically meant for the sidepanel. Therefore the useless collapse button on the top right…

          Daniel Beck added a comment - Not sure this change is correct. Another possibility could be the div tag directly inside j:choose. I'll investigate this. My preferred solution to this particular page is to just get rid of the element anyway, as it's specifically meant for the sidepanel. Therefore the useless collapse button on the top right…

          Could you provide a fix please

          Frederic bonerandi added a comment - Could you provide a fix please

          I modify the file core/src/main/resources/hudson/model/ParametersAction/index.jelly.
          The changed file and the result are attached.

          Frederic bonerandi added a comment - I modify the file core/src/main/resources/hudson/model/ParametersAction/index.jelly. The changed file and the result are attached.

          Daniel Beck added a comment -

          eric The best way to submit a patch is through a GitHub pull request.

          Daniel Beck added a comment - eric The best way to submit a patch is through a GitHub pull request.

          Frederic bonerandi added a comment - https://github.com/jenkinsci/jenkins/pull/1980 coud you add to last LTS

          Daniel Beck added a comment -

          The 1.642.1 RC has already been posted. This could make it into 1.642.2.

          Daniel Beck added a comment - The 1.642.1 RC has already been posted. This could make it into 1.642.2.

          Code changed in jenkins
          User: fbonerandi
          Path:
          core/src/main/resources/hudson/model/ParametersAction/index.jelly
          http://jenkins-ci.org/commit/jenkins/ad22f4dd4fa3214b6cc420cb4abcaf43c7010a9c
          Log:
          JENKINS-31753 Fields are aligned at the bottom

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: fbonerandi Path: core/src/main/resources/hudson/model/ParametersAction/index.jelly http://jenkins-ci.org/commit/jenkins/ad22f4dd4fa3214b6cc420cb4abcaf43c7010a9c Log: JENKINS-31753 Fields are aligned at the bottom

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/model/ParametersAction/index.jelly
          http://jenkins-ci.org/commit/jenkins/11e2e4c7d537ceff611b0ee8a05cd9962edc3c3d
          Log:
          Merge pull request #1987 from fbonerandi/master

          [FIX JENKINS-31753] Fields are aligned at the bottom

          Compare: https://github.com/jenkinsci/jenkins/compare/a3663ee65188...11e2e4c7d537

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/model/ParametersAction/index.jelly http://jenkins-ci.org/commit/jenkins/11e2e4c7d537ceff611b0ee8a05cd9962edc3c3d Log: Merge pull request #1987 from fbonerandi/master [FIX JENKINS-31753] Fields are aligned at the bottom Compare: https://github.com/jenkinsci/jenkins/compare/a3663ee65188...11e2e4c7d537

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4426
          JENKINS-31753 Fields are aligned at the bottom (Revision ad22f4dd4fa3214b6cc420cb4abcaf43c7010a9c)

          Result = SUCCESS
          fbonerandi : ad22f4dd4fa3214b6cc420cb4abcaf43c7010a9c
          Files :

          • core/src/main/resources/hudson/model/ParametersAction/index.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #4426 JENKINS-31753 Fields are aligned at the bottom (Revision ad22f4dd4fa3214b6cc420cb4abcaf43c7010a9c) Result = SUCCESS fbonerandi : ad22f4dd4fa3214b6cc420cb4abcaf43c7010a9c Files : core/src/main/resources/hudson/model/ParametersAction/index.jelly

          Code changed in jenkins
          User: fbonerandi
          Path:
          core/src/main/resources/hudson/model/ParametersAction/index.jelly
          http://jenkins-ci.org/commit/jenkins/c69a88d9adb0ca73827a6d24b68654647526f39f
          Log:
          JENKINS-31753 Fields are aligned at the bottom
          (cherry picked from commit ad22f4dd4fa3214b6cc420cb4abcaf43c7010a9c)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: fbonerandi Path: core/src/main/resources/hudson/model/ParametersAction/index.jelly http://jenkins-ci.org/commit/jenkins/c69a88d9adb0ca73827a6d24b68654647526f39f Log: JENKINS-31753 Fields are aligned at the bottom (cherry picked from commit ad22f4dd4fa3214b6cc420cb4abcaf43c7010a9c)

            eric Frederic bonerandi
            eric Frederic bonerandi
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: