• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None
    • Platform: All, OS: All

      If one enters a node name same as a job name, he gets a warning. See attached image.

          [JENKINS-3176] adding a node wrong name check

          akostadinov added a comment -

          Created an attachment (id=581)
          proof of bug

          akostadinov added a comment - Created an attachment (id=581) proof of bug

          huybrechts added a comment -

          The new slave pages uses Hudson.doItemExistsCheck which checks for job names.
          It should use ComputerSet.checkName somehow.

          huybrechts added a comment - The new slave pages uses Hudson.doItemExistsCheck which checks for job names. It should use ComputerSet.checkName somehow.

          Alan Harder added a comment -

          started

          Alan Harder added a comment - started

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/ComputerSet.java
          trunk/hudson/main/core/src/main/resources/hudson/model/ComputerSet/new.jelly
          trunk/hudson/main/core/src/main/resources/hudson/model/View/newJob.jelly
          trunk/hudson/main/core/src/main/resources/lib/hudson/newFromList/form.jelly
          http://fisheye4.cenqua.com/changelog/hudson/?cs=15939
          Log:
          [FIXED JENKINS-3176] expose ComputerSet.checkName as a form field validator
          and use it on new-slave page (was using Hudson.doItemExistsCheck which checks
          against job names instead of slave names)

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/java/hudson/model/ComputerSet.java trunk/hudson/main/core/src/main/resources/hudson/model/ComputerSet/new.jelly trunk/hudson/main/core/src/main/resources/hudson/model/View/newJob.jelly trunk/hudson/main/core/src/main/resources/lib/hudson/newFromList/form.jelly http://fisheye4.cenqua.com/changelog/hudson/?cs=15939 Log: [FIXED JENKINS-3176] expose ComputerSet.checkName as a form field validator and use it on new-slave page (was using Hudson.doItemExistsCheck which checks against job names instead of slave names)

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/www/changelog.html
          http://fisheye4.cenqua.com/changelog/hudson/?cs=15952
          Log:
          JENKINS-3176 recording the change

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=15952 Log: JENKINS-3176 recording the change

            mindless Alan Harder
            akostadinov akostadinov
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: