Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31832

javaposse.jobdsl.dsl.Job is not a suitable parent class for javaposse.jobdsl.dsl.jobs.WorkflowJob (org.jenkinsci.plugins.workflow.job.WorkflowJob does not extend hudson.model.AbstractProject)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • job-dsl-plugin
    • Jenkins 1.619
      job-dsl-plugin 1.39
      workflow-plugin 1.10

      javaposse.jobdsl.dsl.jobs.WorkflowJob (which matches org.jenkinsci.plugins.workflow.job.WorkflowJob) extends javaposse.jobdsl.dsl.Job (which mainly matches hudson.model.AbstractProject) whereas hudson.model.AbstractProject is not a parent class of org.jenkinsci.plugins.workflow.job.WorkflowJob.
      That results in invalid configuration file being generated when using the javaposse.jobdsl.dsl.Job API combined with javaposse.jobdsl.dsl.DslFactory#workflowJob(java.lang.String, groovy.lang.Closure).
      That means we cannot trust the delegate type to select which customization to apply.

      Closure foo = {
        if (getDelegate() instanceof javaposse.jobdsl.dsl.Job) {
          // label will generate 'assignedNode' / 'canRoam' elements
          label('XXX')
        }
      }
      // below XML is OK, FreeStyleProject has 'assignedNode' / 'canRoam' via AbstractProject
      freeStyleJob('A', foo)
      
      // below resulting XML does not match org.jenkinsci.plugins.workflow.job.WorkflowJob (does not extend AbstractProject)
      workflowJob('B', foo)
      

          [JENKINS-31832] javaposse.jobdsl.dsl.Job is not a suitable parent class for javaposse.jobdsl.dsl.jobs.WorkflowJob (org.jenkinsci.plugins.workflow.job.WorkflowJob does not extend hudson.model.AbstractProject)

          Daniel Spilker added a comment - PR: https://github.com/jenkinsci/job-dsl-plugin/pull/1131

          Basil Crow added a comment -

          Hi daspilker,

          After upgrading to 1.70 I get warnings like this when running Job DSL:

          Processing DSL script blackbox_smoke.groovy
          Warning: (blackbox_smoke.groovy, line 12) concurrentBuild is deprecated
          Warning: (blackbox_smoke.groovy, line 14) authenticationToken is deprecated
          

          Why are concurrentBuild and authenticationToken deprecated? I am using both of these features with Job DSL 1.69 and the latest version of the Pipeline plugin(s). I believe these two have been deprecated by mistake.

          Basil Crow added a comment - Hi daspilker , After upgrading to 1.70 I get warnings like this when running Job DSL: Processing DSL script blackbox_smoke.groovy Warning: (blackbox_smoke.groovy, line 12) concurrentBuild is deprecated Warning: (blackbox_smoke.groovy, line 14) authenticationToken is deprecated Why are concurrentBuild and authenticationToken deprecated? I am using both of these features with Job DSL 1.69 and the latest version of the Pipeline plugin(s). I believe these two have been deprecated by mistake.

          Tianon Gravi added a comment -

          Hitting the same using concurrentBuild(false) on my pipelineJob instances – updated to the following as a workaround:

          configure { it / 'properties' << 'org.jenkinsci.plugins.workflow.job.properties.DisableConcurrentBuildsJobProperty' { } }
          

          (Verified that after doing so, the generated jobs have "Do not allow concurrent builds" checked as expected.)

          Tianon Gravi added a comment - Hitting the same using concurrentBuild(false) on my pipelineJob instances – updated to the following as a workaround: configure { it / 'properties' << 'org.jenkinsci.plugins.workflow.job.properties.DisableConcurrentBuildsJobProperty' { } } (Verified that after doing so, the generated jobs have "Do not allow concurrent builds" checked as expected.)

          David Reaver added a comment -

          I see that {{authenticationToken }}is deprecated. What is the reasoning behind this? It seemed to work great before version 1.70. What are we supposed to use now to enable the remote triggering API?

          I am using this workaround currently:

          configure { Node project ->
              project / authToken("myToken")
          }
          

          David Reaver added a comment - I see that {{authenticationToken }}is deprecated. What is the reasoning behind this? It seemed to work great before version 1.70. What are we supposed to use now to enable the remote triggering API? I am using this workaround currently: configure { Node project -> project / authToken( "myToken" ) }

          As authenticationToken is still configurable in the GUI, what is the new equivalent in the JobDSL?

          Michael Musenbrock added a comment - As authenticationToken is still configurable in the GUI, what is the new equivalent in the JobDSL?

          The next release will fix support for authenticationToken.

          Daniel Spilker added a comment - The next release will fix support for authenticationToken .

          Basil Crow added a comment -

          Hi daspilker,

          I see that you've marked this bug as "Fixed but unreleased"; I'm afraid that it has not yet been fixed. As I wrote in my previous comment, it's not just authenticationToken that has regressed, but also concurrentBuild. Your PR addresses the former, but not the latter.

          Basil Crow added a comment - Hi daspilker , I see that you've marked this bug as "Fixed but unreleased"; I'm afraid that it has not yet been fixed. As I wrote in my previous comment , it's not just authenticationToken that has regressed, but also concurrentBuild . Your PR addresses the former, but not the latter.

          Frank Gen added a comment -

          Hello,

          Will this issue be resolved and released any time soon? We started having builds launched in parallel, even though they should have been queued.

          Thanks

          Frank Gen added a comment - Hello, Will this issue be resolved and released any time soon? We started having builds launched in parallel, even though they should have been queued. Thanks

          Basil Crow added a comment -

          We started having builds launched in parallel, even though they should have been queued.

          franknarf888 You might want to take a look at JENKINS-53775, where I discuss how I solved a similar-sounding problem with Job DSL and concurrent builds.

          Basil Crow added a comment - We started having builds launched in parallel, even though they should have been queued. franknarf888 You might want to take a look at JENKINS-53775 , where I discuss how I solved a similar-sounding problem with Job DSL and concurrent builds.

            jamietanna Jamie Tanna
            fchuong Frédéric Chuong
            Votes:
            0 Vote for this issue
            Watchers:
            16 Start watching this issue

              Created:
              Updated:
              Resolved: