Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31838

Virtual thread dump uses phony filenames

    XMLWordPrintable

Details

    Description

      Discussion

      Currently thread dumps show WorkflowScript.groovy even when you are using Jenkinsfile (or some other CpsScmScriptDefinition filename), and Script1 etc. even when you used load to load a named file. This makes the thread dump confusing for a user, since the line numbers are correct but the filenames are meaningless.

      Attachments

        Issue Links

          is blocking

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-29705 Virtual thread dump

          • Major - Major loss of function.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-32727 Rerun a build with script edits

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-57085 Stack Traces with complex file names cannot be deserialized by XStream

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-41698 Unable to modify the order between scripts loaded during replay

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-35308 Improve display of non-AbortException stack traces such as MissingPropertyException

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/rerun/RerunAction.java
            http://jenkins-ci.org/commit/workflow-plugin/0b1b639e1b14feb1d488e18814487af33be2aec0
            Log:
            Noting JENKINS-31838.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/rerun/RerunAction.java http://jenkins-ci.org/commit/workflow-plugin/0b1b639e1b14feb1d488e18814487af33be2aec0 Log: Noting JENKINS-31838 .
            jglick Jesse Glick added a comment -

            Even more desirable for JENKINS-32727: we would like to refer to Jenkinsfile and servers.groovy, not Main script and Script1.

            jglick Jesse Glick added a comment - Even more desirable for JENKINS-32727 : we would like to refer to Jenkinsfile and servers.groovy , not Main script and Script1 .
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/rerun/RerunAction.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/5cb03cabae608e761c6dd9f97cea29ae69b51427
            Log:
            Noting JENKINS-31838.
            Originally-Committed-As: 0b1b639e1b14feb1d488e18814487af33be2aec0

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/rerun/RerunAction.java http://jenkins-ci.org/commit/workflow-cps-plugin/5cb03cabae608e761c6dd9f97cea29ae69b51427 Log: Noting JENKINS-31838 . Originally-Committed-As: 0b1b639e1b14feb1d488e18814487af33be2aec0
            abayer Andrew Bayer added a comment -

            So legit questions about how much of this we actually would want to implement - Declarative has been making assumptions about Jenkinsfile coming up as WorkflowScript. That'll change as of 1.2, but any earlier version of Declarative has that hardcoded. So changing this could have ramifications.

            That said, handling Script1 for load may make more sense. I don't think anything's depending on that naming.

            abayer Andrew Bayer added a comment - So legit questions about how much of this we actually would want to implement - Declarative has been making assumptions about Jenkinsfile coming up as WorkflowScript . That'll change as of 1.2, but any earlier version of Declarative has that hardcoded. So changing this could have ramifications. That said, handling Script1 for load may make more sense. I don't think anything's depending on that naming.
            jglick Jesse Glick added a comment -

            As per JENKINS-57085, any file name chosen must be without path.

            jglick Jesse Glick added a comment - As per JENKINS-57085 , any file name chosen must be without path.
            dnusbaum Devin Nusbaum added a comment -

            Noting that there are some cases where when someone extends CpsScript you can end up with a stack trace like the following:

            at MyScript.<clinit>(WorkflowScript:3)

            See this comment thread for context.

            dnusbaum Devin Nusbaum added a comment - Noting that there are some cases where when someone extends CpsScript  you can end up with a stack trace like the following: at MyScript.<clinit>(WorkflowScript:3) See this comment thread for context.

            People

              kohsuke Kohsuke Kawaguchi
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: