Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31838

Virtual thread dump uses phony filenames

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Discussion

      Currently thread dumps show WorkflowScript.groovy even when you are using Jenkinsfile (or some other CpsScmScriptDefinition filename), and Script1 etc. even when you used load to load a named file. This makes the thread dump confusing for a user, since the line numbers are correct but the filenames are meaningless.

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is blocking JENKINS-29705 [ JENKINS-29705 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/rerun/RerunAction.java
            http://jenkins-ci.org/commit/workflow-plugin/0b1b639e1b14feb1d488e18814487af33be2aec0
            Log:
            Noting JENKINS-31838.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/rerun/RerunAction.java http://jenkins-ci.org/commit/workflow-plugin/0b1b639e1b14feb1d488e18814487af33be2aec0 Log: Noting JENKINS-31838 .
            Hide
            jglick Jesse Glick added a comment -

            Even more desirable for JENKINS-32727: we would like to refer to Jenkinsfile and servers.groovy, not Main script and Script1.

            Show
            jglick Jesse Glick added a comment - Even more desirable for JENKINS-32727 : we would like to refer to Jenkinsfile and servers.groovy , not Main script and Script1 .
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-32727 [ JENKINS-32727 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/rerun/RerunAction.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/5cb03cabae608e761c6dd9f97cea29ae69b51427
            Log:
            Noting JENKINS-31838.
            Originally-Committed-As: 0b1b639e1b14feb1d488e18814487af33be2aec0

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/rerun/RerunAction.java http://jenkins-ci.org/commit/workflow-cps-plugin/5cb03cabae608e761c6dd9f97cea29ae69b51427 Log: Noting JENKINS-31838 . Originally-Committed-As: 0b1b639e1b14feb1d488e18814487af33be2aec0
            jglick Jesse Glick made changes -
            Epic Link JENKINS-35396 [ 171189 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 167288 ] JNJira + In-Review [ 182675 ]
            abayer Andrew Bayer made changes -
            Component/s pipeline-general [ 21692 ]
            abayer Andrew Bayer made changes -
            Component/s workflow-plugin [ 18820 ]
            jglick Jesse Glick made changes -
            Component/s workflow-cps-plugin [ 21713 ]
            Component/s pipeline [ 21692 ]
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-41698 [ JENKINS-41698 ]
            Hide
            abayer Andrew Bayer added a comment -

            So legit questions about how much of this we actually would want to implement - Declarative has been making assumptions about Jenkinsfile coming up as WorkflowScript. That'll change as of 1.2, but any earlier version of Declarative has that hardcoded. So changing this could have ramifications.

            That said, handling Script1 for load may make more sense. I don't think anything's depending on that naming.

            Show
            abayer Andrew Bayer added a comment - So legit questions about how much of this we actually would want to implement - Declarative has been making assumptions about Jenkinsfile coming up as WorkflowScript . That'll change as of 1.2, but any earlier version of Declarative has that hardcoded. So changing this could have ramifications. That said, handling Script1 for load may make more sense. I don't think anything's depending on that naming.
            Hide
            jglick Jesse Glick added a comment -

            As per JENKINS-57085, any file name chosen must be without path.

            Show
            jglick Jesse Glick added a comment - As per JENKINS-57085 , any file name chosen must be without path.
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-57085 [ JENKINS-57085 ]
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-35308 [ JENKINS-35308 ]
            Hide
            dnusbaum Devin Nusbaum added a comment -

            Noting that there are some cases where when someone extends CpsScript you can end up with a stack trace like the following:

            at MyScript.<clinit>(WorkflowScript:3)
            

            See this comment thread for context.

            Show
            dnusbaum Devin Nusbaum added a comment - Noting that there are some cases where when someone extends CpsScript  you can end up with a stack trace like the following: at MyScript.<clinit>(WorkflowScript:3) See this comment thread for context.
            jequals5 Marky Jackson made changes -
            Epic Link JENKINS-35396 [ 171189 ]

              People

              Assignee:
              kohsuke Kohsuke Kawaguchi
              Reporter:
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated: