Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31843

Gerrit build parameters lost in downstream job if rebuild when using build is parameterized

      Plugins:

      • gerrit-trigger-plugin
      • rebuilder plugin

      Environment:

      • CJE - 1.609.3.1 (also tested with 1.580.3 so version doesn't seem too important)
      • https://github.com/fabric8io/docker-gerrit (gerrit environment - checkout and run scripts in instructions section to setup)
      • gerrit-trigger.xml (attached) (gerrit-trigger-plugin config. keypath needs to change to where docker-gerrit is checked out)
      • upstream job (attached)
      • downstream job (attached)

      Steps to create gerrit event and trigger plugin:

      Note that "This build is parameterized" makes you re-enter the "test" String parameter.
      Also note that when rebuild happens that all the Gerrit build parameters are gone. This doesn't happen when "This buid is parameterized" is removed so suggests that this step is clobbering parameters. But not sure...

      Not sure whether the issue is with:

      • gerrit-trigger-plugin
      • rebuilder plugin
      • Jenkins core

      but seems like a bug IMO.

        1. downstream.xml
          2 kB
        2. gerrit-trigger.xml
          5 kB
        3. upstream.xml
          6 kB

          [JENKINS-31843] Gerrit build parameters lost in downstream job if rebuild when using build is parameterized

          Owen Wood added a comment -

          Looks like rebuilder plugin ignores existing parameters when using "Build is parameterised". Simply merging the existing with the new list collected seems to solve the issue. Note that precedence is given to values coming from "Build is parameterised" if they share the same key (intended to override existing).

          Owen Wood added a comment - Looks like rebuilder plugin ignores existing parameters when using "Build is parameterised". Simply merging the existing with the new list collected seems to solve the issue. Note that precedence is given to values coming from "Build is parameterised" if they share the same key (intended to override existing).

          Owen Wood added a comment -

          Owen Wood added a comment - Created https://github.com/jenkinsci/rebuild-plugin/pull/34 for this

          Antoine Musso added a comment - That might well fix all of: https://issues.jenkins-ci.org/browse/JENKINS-31730 https://issues.jenkins-ci.org/browse/JENKINS-29671 https://issues.jenkins-ci.org/browse/JENKINS-27340 Apparently caused by 1.22 and https://github.com/jenkinsci/rebuild-plugin/pull/19

            owood Owen Wood
            owood Owen Wood
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: