• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • Workflow 1.11
      Jenkins 1.625.2

      When triggering a parameterized job using a build step, default parameters values are not honored when explicitly setting the value of at least one parameter.

      To reproduce it:

      1. Create a parameterized Workflow job (call it "paramd-job"), with 2 string parameters: A, with default value "A" and B with default value "B" and script echo A; echo B
      2. Trigger paramd-job from a second Workflow job using: build job: 'paramd-job', parameters: [[$class: 'StringParameterValue', name: 'A', value: 'Custom value']]

      Expected: paramd-job triggered with A="Custom value" and B="B", both values printed in the build log.
      Actual: B is not defined. groovy.lang.MissingPropertyException: No such property: B for class: WorkflowScript

          [JENKINS-31897] Default parameter value is not used

          Jesse Glick added a comment -

          It is a longstanding open question in Jenkins who is supposed to handle default parameter values and to what extent they are guaranteed to be defined. There is no overall policy or enforced mechanism.

          Jesse Glick added a comment - It is a longstanding open question in Jenkins who is supposed to handle default parameter values and to what extent they are guaranteed to be defined. There is no overall policy or enforced mechanism.

          Agree. So let's assume that no overall policy is defined and just force a policy in Workflow.
          AFAICT we can "force" the default value for undefined parameter values in the incoming JSONArray.fromObject(parameter) here.

          Antonio Muñiz added a comment - Agree. So let's assume that no overall policy is defined and just force a policy in Workflow. AFAICT we can "force" the default value for undefined parameter values in the incoming JSONArray.fromObject(parameter) here .

          Pull request sent.

          Antonio Muñiz added a comment - Pull request sent.

          Code changed in jenkins
          User: Antonio Muñiz
          Path:
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java
          http://jenkins-ci.org/commit/workflow-plugin/c24fd075742ef5034015dec9bed1a28c6cccb5f9
          Log:
          JENKINS-31897 Set default parameters if needed

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java http://jenkins-ci.org/commit/workflow-plugin/c24fd075742ef5034015dec9bed1a28c6cccb5f9 Log: JENKINS-31897 Set default parameters if needed

          Code changed in jenkins
          User: Antonio Muñiz
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          http://jenkins-ci.org/commit/workflow-plugin/229b4d01f32506eab05e307498cfb96cef48cef1
          Log:
          JENKINS-31897 Add a test

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java http://jenkins-ci.org/commit/workflow-plugin/229b4d01f32506eab05e307498cfb96cef48cef1 Log: JENKINS-31897 Add a test

          Code changed in jenkins
          User: Jesse Glick
          Path:
          CHANGES.md
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java
          http://jenkins-ci.org/commit/workflow-plugin/f5fe6534087dd35dcf46de192ad6cfc2390e2ba5
          Log:
          [FIXED JENKINS-31897] Merging #269.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java http://jenkins-ci.org/commit/workflow-plugin/f5fe6534087dd35dcf46de192ad6cfc2390e2ba5 Log: [FIXED JENKINS-31897] Merging #269.

          Code changed in jenkins
          User: Antonio Muñiz
          Path:
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java
          http://jenkins-ci.org/commit/pipeline-build-step-plugin/e55280787c5a323835bc1251d8c5b3b26ba80616
          Log:
          JENKINS-31897 Set default parameters if needed

          Originally-Committed-As: c24fd075742ef5034015dec9bed1a28c6cccb5f9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java http://jenkins-ci.org/commit/pipeline-build-step-plugin/e55280787c5a323835bc1251d8c5b3b26ba80616 Log: JENKINS-31897 Set default parameters if needed Originally-Committed-As: c24fd075742ef5034015dec9bed1a28c6cccb5f9

          Code changed in jenkins
          User: Antonio Muñiz
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          http://jenkins-ci.org/commit/pipeline-build-step-plugin/1e017a720dac44e3f3fde06e9843d41f142276c0
          Log:
          JENKINS-31897 Add a test

          Originally-Committed-As: 229b4d01f32506eab05e307498cfb96cef48cef1

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java http://jenkins-ci.org/commit/pipeline-build-step-plugin/1e017a720dac44e3f3fde06e9843d41f142276c0 Log: JENKINS-31897 Add a test Originally-Committed-As: 229b4d01f32506eab05e307498cfb96cef48cef1

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java
          http://jenkins-ci.org/commit/pipeline-build-step-plugin/5bea30ef67f8f29d793679f3b8a753639b29c0bd
          Log:
          [FIXED JENKINS-31897] Merging #269.

          Originally-Committed-As: f5fe6534087dd35dcf46de192ad6cfc2390e2ba5

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java http://jenkins-ci.org/commit/pipeline-build-step-plugin/5bea30ef67f8f29d793679f3b8a753639b29c0bd Log: [FIXED JENKINS-31897] Merging #269. Originally-Committed-As: f5fe6534087dd35dcf46de192ad6cfc2390e2ba5

            amuniz Antonio Muñiz
            amuniz Antonio Muñiz
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: