Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31932

Performance regression after fixing synchronization issue when setting JDK installations. (issue 28292)

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • Ubuntu 14.04.1 LTS 64bit
      Jenkins ver. 1.625.2
      Java(TM) SE Runtime Environment (build 1.7.0_76-b13)

    Description

      The fix for JENKINS-28292 included in 1.618 is causing performance
      issues - requests are hanging on Jenkins.getJDKs for a very long time
      (sometimes minutes). This does happen on 2 of our Jenkins instances and can be observed at least few times per day by different users. I don't have a thread dump available but I'll try to get it for reference.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-28292 Setting JDK installations not thread-safe

          • Major - Major loss of function.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            lkarnasiewicz Lukasz Karnasiewicz added a comment -

            Fix: https://github.com/jenkinsci/jenkins/pull/1947

            lkarnasiewicz Lukasz Karnasiewicz added a comment - Fix: https://github.com/jenkinsci/jenkins/pull/1947
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Spilker
            Path:
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/9a239081e945f9b1d3076bec59266d01f0857f47
            Log:
            avoid synchronization for Jenkinsget/setJDKs, use a volatile field instead

            [FIXES JENKINS-31932]

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/9a239081e945f9b1d3076bec59266d01f0857f47 Log: avoid synchronization for Jenkinsget/setJDKs, use a volatile field instead [FIXES JENKINS-31932]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/0a5b03688ba6884429bb3d2a06be8b7955694420
            Log:
            Merge pull request #1971 from daspilker/JENKINS-31932

            JENKINS-31932 avoid synchronization for Jenkinsget/setJDKs

            Compare: https://github.com/jenkinsci/jenkins/compare/3f7163207fd7...0a5b03688ba6

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/0a5b03688ba6884429bb3d2a06be8b7955694420 Log: Merge pull request #1971 from daspilker/ JENKINS-31932 JENKINS-31932 avoid synchronization for Jenkinsget/setJDKs Compare: https://github.com/jenkinsci/jenkins/compare/3f7163207fd7...0a5b03688ba6
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/3be09ad1b4392a3a108c2c09abae3c554937b774
            Log:
            Merge pull request #1971 from daspilker/JENKINS-31932

            JENKINS-31932 avoid synchronization for Jenkinsget/setJDKs
            (cherry picked from commit 0a5b03688ba6884429bb3d2a06be8b7955694420)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/3be09ad1b4392a3a108c2c09abae3c554937b774 Log: Merge pull request #1971 from daspilker/ JENKINS-31932 JENKINS-31932 avoid synchronization for Jenkinsget/setJDKs (cherry picked from commit 0a5b03688ba6884429bb3d2a06be8b7955694420)

            People

              lkarnasiewicz Lukasz Karnasiewicz
              lkarnasiewicz Lukasz Karnasiewicz
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: