• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • memegen-plugin
    • None

      Something changed in memegenerator API, no meme is generated and you can see the following in the jenkins log:

      Memegenerator API failure: Procedure or function 'Instance_Create' expects parameter '@Created', which was not supplied., full response: {"errorMessage":"Procedure or function 'Instance_Create' expects parameter '@Created', which was not supplied.","success":false}
      

          [JENKINS-31943] Meme generator plugin is broken

          Jon Cairns added a comment -

          Thanks for reporting this. It's been a long time since I've done anything on the plugin, so I'll familiarise myself with the code again and try and get the API call fixed.

          Jon Cairns added a comment - Thanks for reporting this. It's been a long time since I've done anything on the plugin, so I'll familiarise myself with the code again and try and get the API call fixed.

          Jon Cairns added a comment - - edited

          Ok, the meme generator API is fundamentally broken. This `@Created` parameter looks like a problem with a stored procedure, which is corroborated by an issue on another project.

          I'm giving up on the meme generator API, which I've had a number of problems with over the years. I'm going to swap it out for apimeme.com, which didn't exist when I started this but is exactly what I'm looking for. No need for username/password, and it returns the image as a binary response over HTTP. I'll update progress here.

          Thanks again

          Jon Cairns added a comment - - edited Ok, the meme generator API is fundamentally broken. This `@Created` parameter looks like a problem with a stored procedure, which is corroborated by an issue on another project . I'm giving up on the meme generator API, which I've had a number of problems with over the years. I'm going to swap it out for apimeme.com , which didn't exist when I started this but is exactly what I'm looking for. No need for username/password, and it returns the image as a binary response over HTTP. I'll update progress here. Thanks again

          Jon Cairns added a comment -

          Resolved in version 0.5.1, which uses apimeme.com.

          Jon Cairns added a comment - Resolved in version 0.5.1, which uses apimeme.com.

          Andrew a added a comment -

          Wow, that was fast! Thanks!

          Andrew a added a comment - Wow, that was fast! Thanks!

          Andrew a added a comment -

          Well, not yet. I just compiled and uploaded the plugin onto my jenkins instance. I got the following in the jenkins log:

          Dec 09, 2015 7:18:26 PM hudson.plugins.memegen.MemeNotifier generate
          WARNING: Meme generation failed: null 
          

          and the following in the build log:

          Build failure, generating Meme...
          Generating Meme
          Meme: http://apimeme.com/meme?meme=TED&top=I+don%27t+always+commit&bottom=But+when+I+do%2C+I+break+the+build
          Sorry, couldn't create a Meme - check the logs for more detail
          Finished: FAILURE
          

          Andrew a added a comment - Well, not yet. I just compiled and uploaded the plugin onto my jenkins instance. I got the following in the jenkins log: Dec 09, 2015 7:18:26 PM hudson.plugins.memegen.MemeNotifier generate WARNING: Meme generation failed: null and the following in the build log: Build failure, generating Meme... Generating Meme Meme: http: //apimeme.com/meme?meme=TED&top=I+don%27t+always+commit&bottom=But+when+I+ do %2C+I+ break +the+build Sorry, couldn't create a Meme - check the logs for more detail Finished: FAILURE

          Jon Cairns added a comment -

          Strange! I'll see if I can reproduce it.

          Jon Cairns added a comment - Strange! I'll see if I can reproduce it.

          Jon Cairns added a comment -

          It works for me - that `null` you're getting should be the exception message, which isn't very helpful! Do you get it every time?

          Jon Cairns added a comment - It works for me - that `null` you're getting should be the exception message, which isn't very helpful! Do you get it every time?

          Andrew a added a comment -

          Yes, at least on my installation. I've set up a dev environment - will see if I can debug it myself the nearest weekend and post any followup info.

          Andrew a added a comment - Yes, at least on my installation. I've set up a dev environment - will see if I can debug it myself the nearest weekend and post any followup info.

          Andrew a added a comment -

          Jon, sorry for the delay. I've done a bunch of testing trying to figure out what's going on. It looks like memegen plugin doesn't work nicely with cloudbees docker environment. The error I've posted only happens when building in docker, and since we have all our builds inside containers, I couldn't see that it worked.

          Andrew a added a comment - Jon, sorry for the delay. I've done a bunch of testing trying to figure out what's going on. It looks like memegen plugin doesn't work nicely with cloudbees docker environment. The error I've posted only happens when building in docker, and since we have all our builds inside containers, I couldn't see that it worked.

          Andrew a added a comment -

          Andrew a added a comment - Fixed. See https://github.com/jenkinsci/memegen-plugin/pull/1

            joonty Jon Cairns
            ncrmnt Andrew a
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: