Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32131

Job DSL Plugin extended email pre-send script does not have same default as UI

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • email-ext-plugin, job-dsl-plugin
    • None
    • jenkins 1.625.1
      job-dsl-plugin 1.40
      email-ext 2.40.5

      CONTRIBUTING.md (DSL Design) states that "Every option should have the same defaults as the UI". This is not the case for the extended email plugin.

      When creating an extended email publisher with Job DSL:

      job('example') {
    publishers {
        extendedEmail('me@halfempty.org', 'Oops', 'Something broken')
    }
}

      Pre-send script (under Advanced settings) is left blank.

      After creating an "Editable email notification" from the UI the default is: $DEFAULT_PRESEND_SCRIPT

      This makes it very easy to create jobs which don't use the system specified script. I can add this using a configure block but it would be better if the Job DSL support had the same defaults as in the UI.

          [JENKINS-32131] Job DSL Plugin extended email pre-send script does not have same default as UI

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          docs/Home.md
          docs/Migration.md
          job-dsl-core/src/main/docs/examples/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext/extendedEmail.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/ExtendedEmailContext.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/ExtendedEmailSendToContext.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/ExtendedEmailTriggerContext.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/ExtendedEmailTriggersContext.groovy
          job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext.groovy
          job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextSpec.groovy
          http://jenkins-ci.org/commit/job-dsl-plugin/a4ce20935f5f02ad54f28ba63d0a618dc999d8f2
          Log:
          improved support for Email-ext plugin

          [FIXES JENKINS-28986]
          [FIXES JENKINS-30542]
          [FIXES JENKINS-32131]

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: docs/Home.md docs/Migration.md job-dsl-core/src/main/docs/examples/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext/extendedEmail.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/ExtendedEmailContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/ExtendedEmailSendToContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/ExtendedEmailTriggerContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/ExtendedEmailTriggersContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/a4ce20935f5f02ad54f28ba63d0a618dc999d8f2 Log: improved support for Email-ext plugin [FIXES JENKINS-28986] [FIXES JENKINS-30542] [FIXES JENKINS-32131]

          Daniel Spilker added a comment -

          Will be released in 1.43.

          Daniel Spilker added a comment - Will be released in 1.43.

            daspilker Daniel Spilker
            rg Russell Gallop
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: