Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32377

Upgrade Jetty to fix bugs in cookies

    XMLWordPrintable

Details

    Description

      Jetty is causing bugs in junit and analysis graphs because of cookies for paths with whitespaces. See JENKINS-25917

      Jenkins uses Jetty 8.1.13 (https://github.com/jenkinsci/winstone/blob/master/pom.xml#L221)
      which is buggy (see here and here)

      It is needed to upgrade Jetty to 9.0.6 or later.

      Attachments

        Issue Links

          depends on

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-23378 Raise minimum requirement to servlet 3.1

          • Major - Major loss of function.
          • Resolved
          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25917 Spaces in URL (from project name or view) cause invalid cookies to be saved

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ulli Hafner
            Path:
            src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/GraphConfigurationView.java
            src/test/java/plugins/AbstractAnalysisTest.java
            http://jenkins-ci.org/commit/acceptance-test-harness/b3691320192217d8a2d5e7e60e65119f3b13ea7f
            Log:
            Added a test case that checks trend configuration via cookie.

            Basically a test the checks that JENKINS-25917 and JENKINS-32377 are resolved in Jenkins 2.1.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/GraphConfigurationView.java src/test/java/plugins/AbstractAnalysisTest.java http://jenkins-ci.org/commit/acceptance-test-harness/b3691320192217d8a2d5e7e60e65119f3b13ea7f Log: Added a test case that checks trend configuration via cookie. Basically a test the checks that JENKINS-25917 and JENKINS-32377 are resolved in Jenkins 2.1.
            drulli Ulli Hafner added a comment -

            Fixed in Jenkins 2.x.

            drulli Ulli Hafner added a comment - Fixed in Jenkins 2.x.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ulli Hafner
            Path:
            src/test/java/plugins/AbstractAnalysisTest.java
            http://jenkins-ci.org/commit/acceptance-test-harness/75c8f774c6474f5bfb6a67b256b4acff57a977fc
            Log:
            JENKINS-25917 JENKINS-32377 Let cookie test case run with 2.x only.

            Actually use a job name in the cookie test case that contains spaces.

            Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/00068c6c59b0...75c8f774c647

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/test/java/plugins/AbstractAnalysisTest.java http://jenkins-ci.org/commit/acceptance-test-harness/75c8f774c6474f5bfb6a67b256b4acff57a977fc Log: JENKINS-25917 JENKINS-32377 Let cookie test case run with 2.x only. Actually use a job name in the cookie test case that contains spaces. Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/00068c6c59b0...75c8f774c647

            People

              ci_jenkinsci_org Kohsuke Kawaguchi
              evernat evernat
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: