• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Propose a revision of the parent plugin POM is to decouple this artifact from the Jenkins Core:

      • Simplifying the mechanism to build and test a plugin against different core versions.
      • Decoupling build-related aspects, such as static analysis tools, JRE signatures, etc. from the baseline core versions, as they are totally independent concerns, reducing the need to include otherwise common configuration in each plugin POM just because we want to support and older baseline.

      One use case that would greatly benefit from this change is for example, jenkins#1530, where it is necessary to propose API changes in core and matching plugin usages. The current plugins/pom.xml does not work if you mvn deploy a SNAPSHOT revision. Plugin Compatibility Testing can also benefit from this change.

          [JENKINS-32493] New Parent POM for Jenkins Plugins

          Code changed in jenkins
          User: Jesse Glick
          Path:
          hpi-archetype/pom.xml
          http://jenkins-ci.org/commit/maven-hpi-plugin/c3a868625ed0c2b71482ed0b4f4a5276325ee3fc
          Log:
          Merge pull request #27 from andresrc/newParentPOM

          JENKINS-32493 Adapt to new plugin parent POM

          Compare: https://github.com/jenkinsci/maven-hpi-plugin/compare/5d26cc0cfc18...c3a868625ed0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: hpi-archetype/pom.xml http://jenkins-ci.org/commit/maven-hpi-plugin/c3a868625ed0c2b71482ed0b4f4a5276325ee3fc Log: Merge pull request #27 from andresrc/newParentPOM JENKINS-32493 Adapt to new plugin parent POM Compare: https://github.com/jenkinsci/maven-hpi-plugin/compare/5d26cc0cfc18...c3a868625ed0

          I followed the instructions here:
          https://wiki.jenkins-ci.org/display/JENKINS/Plugin+tutorial#Plugintutorial-CreatingaNewPlugin

          and generated a pom.xml file which still has:

          <groupId>org.jenkins-ci.plugins</groupId>
          <artifactId>plugin</artifactId>
          <!-- Baseline Jenkins version you use to build and test the plugin. Users must have this version or newer to run. -->
          <version>1.580.1</version>
          <relativePath/>
          </parent>

          Can you change things so that your new parent POM changes are reflected in this?

          Craig Rodrigues added a comment - I followed the instructions here: https://wiki.jenkins-ci.org/display/JENKINS/Plugin+tutorial#Plugintutorial-CreatingaNewPlugin and generated a pom.xml file which still has: <groupId>org.jenkins-ci.plugins</groupId> <artifactId>plugin</artifactId> <!-- Baseline Jenkins version you use to build and test the plugin. Users must have this version or newer to run. --> <version>1.580.1</version> <relativePath/> </parent> Can you change things so that your new parent POM changes are reflected in this?

          Code changed in jenkins
          User: Andres Rodriguez
          Path:
          pom.xml
          src/main/resources/index.jelly
          http://jenkins-ci.org/commit/branch-api-plugin/558ddcb1223afdae020e4ca29374f00fcb478ae9
          Log:
          JENKINS-32493 Adapt to Parent POM 2.3.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andres Rodriguez Path: pom.xml src/main/resources/index.jelly http://jenkins-ci.org/commit/branch-api-plugin/558ddcb1223afdae020e4ca29374f00fcb478ae9 Log: JENKINS-32493 Adapt to Parent POM 2.3.

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/resources/index.jelly
          http://jenkins-ci.org/commit/branch-api-plugin/1df138d8e64b45e985c3ecd8bd48628bcde4a70f
          Log:
          Merge pull request #26 from andresrc/newParentPOM

          JENKINS-32493 Adapt to Parent POM 2.3.

          Compare: https://github.com/jenkinsci/branch-api-plugin/compare/178b3d1ef30a...1df138d8e64b

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/resources/index.jelly http://jenkins-ci.org/commit/branch-api-plugin/1df138d8e64b45e985c3ecd8bd48628bcde4a70f Log: Merge pull request #26 from andresrc/newParentPOM JENKINS-32493 Adapt to Parent POM 2.3. Compare: https://github.com/jenkinsci/branch-api-plugin/compare/178b3d1ef30a...1df138d8e64b

          Code changed in jenkins
          User: Andres Rodriguez
          Path:
          pom.xml
          src/main/resources/index.jelly
          src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest.java
          src/test/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApprovalTest.java
          http://jenkins-ci.org/commit/script-security-plugin/1b010247984b0cd51dc51c68a9bc32cad7f14699
          Log:
          JENKINS-32493 Baseline 1.580.1 and Parent POM 2.3

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andres Rodriguez Path: pom.xml src/main/resources/index.jelly src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest.java src/test/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApprovalTest.java http://jenkins-ci.org/commit/script-security-plugin/1b010247984b0cd51dc51c68a9bc32cad7f14699 Log: JENKINS-32493 Baseline 1.580.1 and Parent POM 2.3

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/resources/index.jelly
          src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest.java
          src/test/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApprovalTest.java
          http://jenkins-ci.org/commit/script-security-plugin/414d49ea3ad5fde7c3bba87ce1c5c42a4398651c
          Log:
          Merge pull request #36 from andresrc/newParentPOM

          JENKINS-32493 Baseline 1.580.1 and Parent POM 2.3

          Compare: https://github.com/jenkinsci/script-security-plugin/compare/0a0df011b206...414d49ea3ad5

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/resources/index.jelly src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest.java src/test/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApprovalTest.java http://jenkins-ci.org/commit/script-security-plugin/414d49ea3ad5fde7c3bba87ce1c5c42a4398651c Log: Merge pull request #36 from andresrc/newParentPOM JENKINS-32493 Baseline 1.580.1 and Parent POM 2.3 Compare: https://github.com/jenkinsci/script-security-plugin/compare/0a0df011b206...414d49ea3ad5

          Code changed in jenkins
          User: Andres Rodriguez
          Path:
          pom.xml
          src/main/java/jenkins/scm/api/SCMFile.java
          src/main/java/jenkins/scm/api/SCMFileSystem.java
          src/main/java/jenkins/scm/api/SCMRevisionAction.java
          src/main/java/jenkins/scm/api/SCMSource.java
          src/main/java/jenkins/scm/api/SCMSourceCriteria.java
          src/main/java/jenkins/scm/api/SCMSourceOwners.java
          src/main/java/jenkins/scm/impl/SingleSCMSource.java
          src/main/resources/index.jelly
          src/main/resources/jenkins/scm/api/SCMSource/config.jelly
          src/main/resources/jenkins/scm/impl/SingleSCMSource/config-detail.jelly
          http://jenkins-ci.org/commit/scm-api-plugin/a32235dfe8f28a824c8d2790616ab8f001f69320
          Log:
          JENKINS-32493 Adapt to new parent POM.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andres Rodriguez Path: pom.xml src/main/java/jenkins/scm/api/SCMFile.java src/main/java/jenkins/scm/api/SCMFileSystem.java src/main/java/jenkins/scm/api/SCMRevisionAction.java src/main/java/jenkins/scm/api/SCMSource.java src/main/java/jenkins/scm/api/SCMSourceCriteria.java src/main/java/jenkins/scm/api/SCMSourceOwners.java src/main/java/jenkins/scm/impl/SingleSCMSource.java src/main/resources/index.jelly src/main/resources/jenkins/scm/api/SCMSource/config.jelly src/main/resources/jenkins/scm/impl/SingleSCMSource/config-detail.jelly http://jenkins-ci.org/commit/scm-api-plugin/a32235dfe8f28a824c8d2790616ab8f001f69320 Log: JENKINS-32493 Adapt to new parent POM.

          Code changed in jenkins
          User: Andres Rodriguez
          Path:
          src/main/java/jenkins/scm/api/SCMFileSystem.java
          src/main/java/jenkins/scm/api/SCMHead.java
          src/main/java/jenkins/scm/api/SCMSourceOwners.java
          http://jenkins-ci.org/commit/scm-api-plugin/4e5390964b230ea7cb9c2ddcf15816528a36e580
          Log:
          JENKINS-32493 Move to ExtensionList.lookup

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andres Rodriguez Path: src/main/java/jenkins/scm/api/SCMFileSystem.java src/main/java/jenkins/scm/api/SCMHead.java src/main/java/jenkins/scm/api/SCMSourceOwners.java http://jenkins-ci.org/commit/scm-api-plugin/4e5390964b230ea7cb9c2ddcf15816528a36e580 Log: JENKINS-32493 Move to ExtensionList.lookup

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/jenkins/scm/api/SCMFile.java
          src/main/java/jenkins/scm/api/SCMFileSystem.java
          src/main/java/jenkins/scm/api/SCMHead.java
          src/main/java/jenkins/scm/api/SCMRevisionAction.java
          src/main/java/jenkins/scm/api/SCMSource.java
          src/main/java/jenkins/scm/api/SCMSourceCriteria.java
          src/main/java/jenkins/scm/api/SCMSourceOwners.java
          src/main/java/jenkins/scm/impl/SingleSCMSource.java
          src/main/resources/index.jelly
          src/main/resources/jenkins/scm/api/SCMSource/config.jelly
          src/main/resources/jenkins/scm/impl/SingleSCMSource/config-detail.jelly
          http://jenkins-ci.org/commit/scm-api-plugin/a5027b596c4152167f6a1a4789b6db1e0748c7bb
          Log:
          Merge pull request #6 from andresrc/JENKINS-32493

          JENKINS-32493 Adapt to new parent POM.

          Compare: https://github.com/jenkinsci/scm-api-plugin/compare/891ef066e09c...a5027b596c41

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/scm/api/SCMFile.java src/main/java/jenkins/scm/api/SCMFileSystem.java src/main/java/jenkins/scm/api/SCMHead.java src/main/java/jenkins/scm/api/SCMRevisionAction.java src/main/java/jenkins/scm/api/SCMSource.java src/main/java/jenkins/scm/api/SCMSourceCriteria.java src/main/java/jenkins/scm/api/SCMSourceOwners.java src/main/java/jenkins/scm/impl/SingleSCMSource.java src/main/resources/index.jelly src/main/resources/jenkins/scm/api/SCMSource/config.jelly src/main/resources/jenkins/scm/impl/SingleSCMSource/config-detail.jelly http://jenkins-ci.org/commit/scm-api-plugin/a5027b596c4152167f6a1a4789b6db1e0748c7bb Log: Merge pull request #6 from andresrc/ JENKINS-32493 JENKINS-32493 Adapt to new parent POM. Compare: https://github.com/jenkinsci/scm-api-plugin/compare/891ef066e09c...a5027b596c41

          Code changed in jenkins
          User: Andres Rodriguez
          Path:
          pom.xml
          src/main/java/hudson/plugins/copyartifact/BuildSelector.java
          src/main/java/hudson/plugins/copyartifact/BuildSelectorParameter.java
          src/main/java/hudson/plugins/copyartifact/Copier.java
          src/main/java/hudson/plugins/copyartifact/CopyArtifact.java
          src/main/java/hudson/plugins/copyartifact/CopyArtifactPermissionProperty.java
          src/main/java/hudson/plugins/copyartifact/DownstreamBuildSelector.java
          src/main/java/hudson/plugins/copyartifact/FilePathCopyMethod.java
          src/main/java/hudson/plugins/copyartifact/SimpleBuildSelectorDescriptor.java
          src/main/resources/index.jelly
          src/test/java/hudson/plugins/copyartifact/BuildSelectorParameterTest.java
          src/test/java/hudson/plugins/copyartifact/CopyArtifactPermissionPropertyTest.java
          src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
          src/test/java/hudson/plugins/copyartifact/TriggeredBuildSelectorTest.java
          http://jenkins-ci.org/commit/copyartifact-plugin/75b91e5cba74c7386f537270b661ca46e87d11c8
          Log:
          JENKINS-32493 Adapt to Parent POM 2.3 and JTH 2.1

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andres Rodriguez Path: pom.xml src/main/java/hudson/plugins/copyartifact/BuildSelector.java src/main/java/hudson/plugins/copyartifact/BuildSelectorParameter.java src/main/java/hudson/plugins/copyartifact/Copier.java src/main/java/hudson/plugins/copyartifact/CopyArtifact.java src/main/java/hudson/plugins/copyartifact/CopyArtifactPermissionProperty.java src/main/java/hudson/plugins/copyartifact/DownstreamBuildSelector.java src/main/java/hudson/plugins/copyartifact/FilePathCopyMethod.java src/main/java/hudson/plugins/copyartifact/SimpleBuildSelectorDescriptor.java src/main/resources/index.jelly src/test/java/hudson/plugins/copyartifact/BuildSelectorParameterTest.java src/test/java/hudson/plugins/copyartifact/CopyArtifactPermissionPropertyTest.java src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java src/test/java/hudson/plugins/copyartifact/TriggeredBuildSelectorTest.java http://jenkins-ci.org/commit/copyartifact-plugin/75b91e5cba74c7386f537270b661ca46e87d11c8 Log: JENKINS-32493 Adapt to Parent POM 2.3 and JTH 2.1

            andresrc Andres Rodriguez
            andresrc Andres Rodriguez
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: