Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32670

Improperly filtered branch properties for multibranch pipelines

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • branch-api-plugin
    • Jenkins 1.625.2 and github-branch-source-plugin 1.0
      Jenkins 1.642.1 and github-branch-source-plugin 1.1

    Description

      Steps to reproduce:

      • Create a multibranch project with a Github Branch Source
      • Save the config (with or without adding a property)
      • Open the config page: when clicking "Add Property" nothing happens.

      In the dev console you get:

      Uncaught TypeError: Cannot read property 'value' of undefined
hasChanged @ select.js:46
updateListBox.onSuccess @ select.js:76
config.onSuccess @ select.js:32
Ajax.Request.Class.create.respondToReadyState @ prototype.js:1657
Ajax.Request.Class.create.onStateChange @ prototype.js:1600
(anonymous function) @ prototype.js:414

      at hudson-behavior.js:2948

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19565 dropdownDescriptorSelector is loosing the context of `it`

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link PR 32

          Web Link workflow-plugin PR 365

          Activity

            Ascending order - Click to sort in descending order
            View 7 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            multibranch/pom.xml
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java
            http://jenkins-ci.org/commit/workflow-plugin/96460b497b3427fcfba461fbcf45933318b91b34
            Log:
            JENKINS-32670 Integration test showing that branch property strategies are hidden by default for multibranch Pipeline projects.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: multibranch/pom.xml multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java http://jenkins-ci.org/commit/workflow-plugin/96460b497b3427fcfba461fbcf45933318b91b34 Log: JENKINS-32670 Integration test showing that branch property strategies are hidden by default for multibranch Pipeline projects.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java
            http://jenkins-ci.org/commit/workflow-plugin/d75fc7c8999b6d1d7bb9d98ecd81d100c3f4ae7a
            Log:
            Merge pull request #365 from jglick/branch-property-filtering-JENKINS-32670

            JENKINS-32670 Integration test

            Compare: https://github.com/jenkinsci/workflow-plugin/compare/5b4c683a801a...d75fc7c8999b

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java http://jenkins-ci.org/commit/workflow-plugin/d75fc7c8999b6d1d7bb9d98ecd81d100c3f4ae7a Log: Merge pull request #365 from jglick/branch-property-filtering- JENKINS-32670 JENKINS-32670 Integration test Compare: https://github.com/jenkinsci/workflow-plugin/compare/5b4c683a801a...d75fc7c8999b
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            multibranch/pom.xml
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/7c2e34e393ef8ee14f6d3d7865a1f2cc632bb092
            Log:
            JENKINS-32670 Integration test showing that branch property strategies are hidden by default for multibranch Pipeline projects.
            Originally-Committed-As: 96460b497b3427fcfba461fbcf45933318b91b34

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: multibranch/pom.xml multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/7c2e34e393ef8ee14f6d3d7865a1f2cc632bb092 Log: JENKINS-32670 Integration test showing that branch property strategies are hidden by default for multibranch Pipeline projects. Originally-Committed-As: 96460b497b3427fcfba461fbcf45933318b91b34
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/45c2d5bd3001b062133d5308309884d5c4b31c8f
            Log:
            Merge pull request #365 from jglick/branch-property-filtering-JENKINS-32670

            JENKINS-32670 Integration test
            Originally-Committed-As: d75fc7c8999b6d1d7bb9d98ecd81d100c3f4ae7a

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/45c2d5bd3001b062133d5308309884d5c4b31c8f Log: Merge pull request #365 from jglick/branch-property-filtering- JENKINS-32670 JENKINS-32670 Integration test Originally-Committed-As: d75fc7c8999b6d1d7bb9d98ecd81d100c3f4ae7a
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/4e5b39efc03ff86836aa09f09a444fabc8c523d4
            Log:
            As of JENKINS-32396, JENKINS-32670 is irrelevant since we do have a legitimate BranchProperty.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/4e5b39efc03ff86836aa09f09a444fabc8c523d4 Log: As of JENKINS-32396 , JENKINS-32670 is irrelevant since we do have a legitimate BranchProperty.

            People

              jglick Jesse Glick
              andresrc Andres Rodriguez
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: