Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32670

Improperly filtered branch properties for multibranch pipelines

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • branch-api-plugin
    • Jenkins 1.625.2 and github-branch-source-plugin 1.0
      Jenkins 1.642.1 and github-branch-source-plugin 1.1

      Steps to reproduce:

      • Create a multibranch project with a Github Branch Source
      • Save the config (with or without adding a property)
      • Open the config page: when clicking "Add Property" nothing happens.

      In the dev console you get:

      Uncaught TypeError: Cannot read property 'value' of undefined
hasChanged @ select.js:46
updateListBox.onSuccess @ select.js:76
config.onSuccess @ select.js:32
Ajax.Request.Class.create.respondToReadyState @ prototype.js:1657
Ajax.Request.Class.create.onStateChange @ prototype.js:1600
(anonymous function) @ prototype.js:414

      at hudson-behavior.js:2948

          [JENKINS-32670] Improperly filtered branch properties for multibranch pipelines

          Andres Rodriguez created issue -

          Antonio Muñiz added a comment -

          Is this happening in 1.625.1? I suspect this bug was introduced in 1.625.2 (so the bug is not really in github-branch-source-plugin but Jenkins core).

          Antonio Muñiz added a comment - Is this happening in 1.625.1? I suspect this bug was introduced in 1.625.2 (so the bug is not really in github-branch-source-plugin but Jenkins core).

          Jesse Glick added a comment -

          There are no branch properties to add unless you install some additional plugins providing some. So the bug is merely that this control is shown when there are no applicable entries.

          Jesse Glick added a comment - There are no branch properties to add unless you install some additional plugins providing some. So the bug is merely that this control is shown when there are no applicable entries.
          Jesse Glick made changes -
          Component/s New: branch-api-plugin [ 18621 ]
          Component/s Original: github-branch-source-plugin [ 20858 ]
          Assignee Original: Manuel Recena Soto [ recena ]
          Summary Original: Unable to Set Build Properties New: No branch properties for multibranch pipelines
          Patrick Wolf made changes -
          Labels New: 2.0
          Jesse Glick made changes -
          Assignee New: Jesse Glick [ jglick ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Jesse Glick added a comment -

          Worse than that: when the source is first added, rather than reloading the configuration form, all branch properties are displayed (including ones which multibranch Pipeline does not intend to support), because it == null.

          Jesse Glick added a comment - Worse than that: when the source is first added, rather than reloading the configuration form, all branch properties are displayed (including ones which multibranch Pipeline does not intend to support), because it == null .
          Jesse Glick made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          Summary Original: No branch properties for multibranch pipelines New: Improperly filtered branch properties for multibranch pipelines

          Jesse Glick added a comment -

          …because of JENKINS-19565, as used here.

          Jesse Glick added a comment - …because of JENKINS-19565 , as used here .
          Jesse Glick made changes -
          Link New: This issue depends on JENKINS-19565 [ JENKINS-19565 ]

            jglick Jesse Glick
            andresrc Andres Rodriguez
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: