Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3277

Clover Weather Report on main page does not use criteria

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • clover-plugin
    • None
    • Platform: PC, OS: Linux

      It looks like the clover weather report does not use the customized Coverage
      Metric Targets, it just uses the default values.

      I set the metrics for sunny to be less than the reported values and it still
      shows cloudy.

          [JENKINS-3277] Clover Weather Report on main page does not use criteria

          npellow added a comment -

          HI bhayward,

          The health config screen for Clover is a bit confusing...
          Can you please ensure that you have no unhealthy thresholds set?

          Also - I am thinking of simplifying the config screen somewhat by just allowing the configuration of the
          Total Percentage Coverage. What are your thoughts on that? Do you really need to check for
          method/conditional/statement coverage separately?

          Cheers,
          Nick

          npellow added a comment - HI bhayward, The health config screen for Clover is a bit confusing... Can you please ensure that you have no unhealthy thresholds set? Also - I am thinking of simplifying the config screen somewhat by just allowing the configuration of the Total Percentage Coverage. What are your thoughts on that? Do you really need to check for method/conditional/statement coverage separately? Cheers, Nick

          bhayward added a comment -

          My Clover Coverage Metrics are:
          In the "Sunny" row, I have: 50 50 50
          All other rows are left empty.

          Current statistics from this project are:
          Methods 65% Conditionals 59% Statements 65%

          The weather report on the main page shows this:
          Clover Coverage: Elements: 64%

          If the main page uses average for weather, it doesn't make sense to set the
          weather metrics for each one. So I agree with simplifying it.


          Brian

          bhayward added a comment - My Clover Coverage Metrics are: In the "Sunny" row, I have: 50 50 50 All other rows are left empty. Current statistics from this project are: Methods 65% Conditionals 59% Statements 65% The weather report on the main page shows this: Clover Coverage: Elements: 64% If the main page uses average for weather, it doesn't make sense to set the weather metrics for each one. So I agree with simplifying it. – Brian

          Also, if no statment ( 0 / 0 ), the weather report is bad.
          I'm using bullseys, and bullshtml.exe is hardcoded to give report 0 statments (Bullseys dont use statment coverage). Then I set the config for clover to be sunny at 0% statement coverage, but this dont work on the weather report on the main page.

          cheers
          Torben

          Torben Pedersen added a comment - Also, if no statment ( 0 / 0 ), the weather report is bad. I'm using bullseys, and bullshtml.exe is hardcoded to give report 0 statments (Bullseys dont use statment coverage). Then I set the config for clover to be sunny at 0% statement coverage, but this dont work on the weather report on the main page. cheers Torben

          Juan Sotuyo added a comment - - edited

          +1
          The issue of 0/0 giving a stormy weather report is affecting me too on PHP projects, that don't use conditionals.

          There has already been an issue for PHP and conditionals and graphs (check https://issues.jenkins-ci.org/browse/JENKINS-8198), but the health report is still considering these as 0% and giving a bad rating to the project's health.

          Juan Sotuyo added a comment - - edited +1 The issue of 0/0 giving a stormy weather report is affecting me too on PHP projects, that don't use conditionals. There has already been an issue for PHP and conditionals and graphs (check https://issues.jenkins-ci.org/browse/JENKINS-8198 ), but the health report is still considering these as 0% and giving a bad rating to the project's health.

          I am also having issues with this for my PHP project. I have tried setting the % Methods and % Statements thresholds to 0 and -1 and they are ignored (I only have those two types). My build shows as stormy due to "Clover Coverage: Elements 9% (214/2514)"

          Shaddy Zeineddine added a comment - I am also having issues with this for my PHP project. I have tried setting the % Methods and % Statements thresholds to 0 and -1 and they are ignored (I only have those two types). My build shows as stormy due to "Clover Coverage: Elements 9% (214/2514)"

          Nick Johns added a comment -

          This problem is affecting my project too.

          The administration screen for the coverage thresholds is missing a setting. I can work around this by manually set this setting in the XML config for the job by adding an "elementCoverage" element with the required value. This results in builds correctly reflecting the weather report.

          However when making changes to the job via the Jenkins interface this element is lost, requiring me to reapply the manual change.

          Please add the elementCoverage fields to the admin screen.

          Cheers,

          Nick

          Nick Johns added a comment - This problem is affecting my project too. The administration screen for the coverage thresholds is missing a setting. I can work around this by manually set this setting in the XML config for the job by adding an "elementCoverage" element with the required value. This results in builds correctly reflecting the weather report. However when making changes to the job via the Jenkins interface this element is lost, requiring me to reapply the manual change. Please add the elementCoverage fields to the admin screen. Cheers, Nick

          Oleg I added a comment -

          This problem is affecting my project too.

          Adding "elementCoverage" to configuration screen may be a correct solution?

          Oleg I added a comment - This problem is affecting my project too. Adding "elementCoverage" to configuration screen may be a correct solution?

          most wanted added a comment -

          This problem is affecting my project too.

          most wanted added a comment - This problem is affecting my project too.

            Unassigned Unassigned
            bhayward bhayward
            Votes:
            7 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated: