Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32986

hard killing a pipeline leaves the JVM CPS thread running.

    XMLWordPrintable

Details

    • Improvement
    • Status: Open (View Workflow)
    • Minor
    • Resolution: Unresolved
    • workflow-cps-plugin
    • None
    • pipeline 1.13
      jenkins 1.642.1

    Description

      In the event a pipeline build will not die you can hard kill it - however hard killing it will leave the JVMs CPS thread still running on the master.

      e.g. with the script

      def spin() {
    while (true) {}
}

def map = [:]
map ["spin_it"] = { spin() } 
}
parallel map

      you will need to hard kill it to stop it (on windows at least) - but inspecting the JVM threads you can see the CPS thread is still running in a tight loop.
      A hard kill should probably (if it is safe without causing deadlocks elsewhere) brutally kill the thread as well. After a while you may run out of handles or other native resources due to the thread usage, meaning you need to restart Jenkins to get it working again.

      Attachments

        Issue Links

          is blocking

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-25550 Hard kill

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-25623 timeout step should be able to kill infinite loop

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-45772 Build cannot be aborted when plugin is in waitUntilContainerIsReady

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-31484 Endless loop in DefaultInvoker.getProperty when accessing field via getter/setter without @

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-37719 Build cannot be interrupted if `docker stop` hangs

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-30978 URLConnection.content.text hangs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-32228 Event when timeout is reach should be customizable

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-43276 CoreWrapperStep should run SimpleBuildWrapper.setUp asynchronously

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-47006 durable-task's BourneShellScript.launchWithCookie trips workflow-cps-plugin's 5-minute timeout

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-44785 Add Built-in Request timeout support in Remoting

          • Major - Major loss of function.
          • In Review

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-42561 Users should be able to custom configure the timeout on pipeline build wrappers/steps

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link CloudBees Internal OSS-1488

          Web Link workflow-cps PR 102

          Web Link workflow-support PR 29

          Web Link workflow-support PR 37

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/support/concurrent/Timeout.java
            src/test/java/org/jenkinsci/plugins/workflow/support/concurrent/TimeoutTest.java
            http://jenkins-ci.org/commit/workflow-support-plugin/c810b3874134f60be670d1205b6673fde5003c14
            Log:
            JENKINS-32986 Introducing a general-purpose Timeout utility.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/support/concurrent/Timeout.java src/test/java/org/jenkinsci/plugins/workflow/support/concurrent/TimeoutTest.java http://jenkins-ci.org/commit/workflow-support-plugin/c810b3874134f60be670d1205b6673fde5003c14 Log: JENKINS-32986 Introducing a general-purpose Timeout utility.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/support/concurrent/Timeout.java
            src/test/java/org/jenkinsci/plugins/workflow/support/concurrent/TimeoutTest.java
            http://jenkins-ci.org/commit/workflow-support-plugin/957d76a5538747f85db6f9ae33f076ee435f534b
            Log:
            Merge pull request #29 from jglick/Timeout-JENKINS-32986

            JENKINS-32986 Introducing a general-purpose Timeout utility

            Compare: https://github.com/jenkinsci/workflow-support-plugin/compare/eb031e04d6e3...957d76a55387

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/support/concurrent/Timeout.java src/test/java/org/jenkinsci/plugins/workflow/support/concurrent/TimeoutTest.java http://jenkins-ci.org/commit/workflow-support-plugin/957d76a5538747f85db6f9ae33f076ee435f534b Log: Merge pull request #29 from jglick/Timeout- JENKINS-32986 JENKINS-32986 Introducing a general-purpose Timeout utility Compare: https://github.com/jenkinsci/workflow-support-plugin/compare/eb031e04d6e3...957d76a55387
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecution.java
            src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThread.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/c0deed0a3b546ebcb59ea25681ed3ac8b13fe6bb
            Log:
            JENKINS-32986 Apply a timeout to some hang-prone operations in the CPS VM thread.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecution.java src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThread.java http://jenkins-ci.org/commit/workflow-cps-plugin/c0deed0a3b546ebcb59ea25681ed3ac8b13fe6bb Log: JENKINS-32986 Apply a timeout to some hang-prone operations in the CPS VM thread.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecution.java
            src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThread.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/51c02d40783bdc2be4e825d29c4c28286aa8c1dc
            Log:
            Merge pull request #102 from jglick/Timeout-JENKINS-32986

            JENKINS-32986 Apply a timeout to some hang-prone operations in the CPS VM thread

            Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/8da4ed31126f...51c02d40783b

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecution.java src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThread.java http://jenkins-ci.org/commit/workflow-cps-plugin/51c02d40783bdc2be4e825d29c4c28286aa8c1dc Log: Merge pull request #102 from jglick/Timeout- JENKINS-32986 JENKINS-32986 Apply a timeout to some hang-prone operations in the CPS VM thread Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/8da4ed31126f...51c02d40783b
            jglick Jesse Glick added a comment -

            workflow-support PR 37 should fix the SerializableClassRegistry issue.

            jglick Jesse Glick added a comment - workflow-support PR 37 should fix the SerializableClassRegistry issue.

            People

              jglick Jesse Glick
              teilo James Nord
              Votes:
              4 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

                Created:
                Updated: