If you click on logs button of an stage, and you scroll up, you can see the log popup window, but if you try to expand the entries to see the logs, nothing happens.

          [JENKINS-33110] Log details are not shown

          Deniz Ugurlu added a comment -

          In addition to the mentioned warning in the browser console, it looks like the click event on .node-name is fired twice when clicked.
          This toggles activation/deactivation on the log entry twice, effectively returning to the initial state. See ui/src/main/js/view/stage-logs.js:

          [...]
          var nodeNameBars = $('.node-name', stageLogsDom);
          [...]
          
          nodeNameBars.click(function() {
            // this handler is getting called twice per click for me
          });
          

          Maybe it helps to extract the registration of the click-handler from dialog.show(onshow())?

          Deniz Ugurlu added a comment - In addition to the mentioned warning in the browser console, it looks like the click event on .node-name is fired twice when clicked. This toggles activation/deactivation on the log entry twice, effectively returning to the initial state. See ui/src/main/js/view/stage-logs.js : [...] var nodeNameBars = $( '.node-name' , stageLogsDom); [...] nodeNameBars.click( function () { // this handler is getting called twice per click for me }); Maybe it helps to extract the registration of the click-handler from dialog.show(onshow()) ?

          Jesse Glick added a comment -

          the build history widget does not update…

          Filed separately as JENKINS-33589.

          Jesse Glick added a comment - the build history widget does not update… Filed separately as JENKINS-33589 .

          Daniel Beck added a comment -

          svanoort Are you still working on this?

          If not:
          hrmpw WDYT? Looks like a pretty popular issue.

          Daniel Beck added a comment - svanoort Are you still working on this? If not: hrmpw WDYT? Looks like a pretty popular issue.

          Sam Van Oort added a comment -

          danielbeck Yes, I am aware, it has been root caused and should be a small, easy fix that can be implemented once the most critical of the scalability enhancements in https://issues.jenkins-ci.org/browse/JENKINS-33624 is ready for release inclusion, since it is more complex (harder to return to after a context-switch). This & that will be the final items before we cut a pipeline stage view release.

          I believe that amuniz volunteered to work on this now since he has capacity right now and is free to dump context.

          Sam Van Oort added a comment - danielbeck Yes, I am aware, it has been root caused and should be a small, easy fix that can be implemented once the most critical of the scalability enhancements in https://issues.jenkins-ci.org/browse/JENKINS-33624 is ready for release inclusion, since it is more complex (harder to return to after a context-switch). This & that will be the final items before we cut a pipeline stage view release. I believe that amuniz volunteered to work on this now since he has capacity right now and is free to dump context.

          Antonio Muñiz added a comment - PR sent: https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/5

          Code changed in jenkins
          User: Antonio Muñiz
          Path:
          ui/src/main/js/view/stage-logs.js
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/f5a7cdbc25d1bba84eb8aa6b1b448dc589e42ea7
          Log:
          JENKINS-33110 Fixed regression in stage logs dialog + log sections not expanded right when there are more than 15-20 steps in the same stage

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: ui/src/main/js/view/stage-logs.js http://jenkins-ci.org/commit/pipeline-stage-view-plugin/f5a7cdbc25d1bba84eb8aa6b1b448dc589e42ea7 Log: JENKINS-33110 Fixed regression in stage logs dialog + log sections not expanded right when there are more than 15-20 steps in the same stage

          Code changed in jenkins
          User: Antonio Muñiz
          Path:
          ui/src/main/js/view/templates/stage-logs.less
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/6a4c14878b1a6bfd320169eaf6e254164affea9a
          Log:
          JENKINS-33110 Every log section have a maximum height (which forces scroll)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: ui/src/main/js/view/templates/stage-logs.less http://jenkins-ci.org/commit/pipeline-stage-view-plugin/6a4c14878b1a6bfd320169eaf6e254164affea9a Log: JENKINS-33110 Every log section have a maximum height (which forces scroll)

          Code changed in jenkins
          User: Antonio Muñiz
          Path:
          ui/src/test/js/view/stage-logs-spec.js
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/91497d51b17ad079f35a8e75fcc92719724a33ab
          Log:
          JENKINS-33110 Test it

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: ui/src/test/js/view/stage-logs-spec.js http://jenkins-ci.org/commit/pipeline-stage-view-plugin/91497d51b17ad079f35a8e75fcc92719724a33ab Log: JENKINS-33110 Test it

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          ui/src/main/js/view/stage-logs.js
          ui/src/main/js/view/templates/stage-logs.hbs
          ui/src/main/js/view/templates/stage-logs.less
          ui/src/test/js/view/stage-logs-spec.js
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/44ef3e5bbd4e61033b9c0847d8ef6ec1b02624e7
          Log:
          Merge pull request #5 from amuniz/JENKINS-33110

          JENKINS-33110 Log details not shown

          Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/e99d804ebbe4...44ef3e5bbd4e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: ui/src/main/js/view/stage-logs.js ui/src/main/js/view/templates/stage-logs.hbs ui/src/main/js/view/templates/stage-logs.less ui/src/test/js/view/stage-logs-spec.js http://jenkins-ci.org/commit/pipeline-stage-view-plugin/44ef3e5bbd4e61033b9c0847d8ef6ec1b02624e7 Log: Merge pull request #5 from amuniz/ JENKINS-33110 JENKINS-33110 Log details not shown Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/e99d804ebbe4...44ef3e5bbd4e

          Sam Van Oort added a comment -

          released and verified.

          Sam Van Oort added a comment - released and verified.

            amuniz Antonio Muñiz
            asotobueno Alex Soto
            Votes:
            12 Vote for this issue
            Watchers:
            20 Start watching this issue

              Created:
              Updated:
              Resolved: