Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33374

Setup wizard not properly offering the restart button

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      The setup wizard is not offering the restart button properly, nor was it checking `Lifecycle.canRestart()`, and it puts up the restart button even when the system doesn't support it.

      The message should be modified to request manual restart in the latter case.

          [JENKINS-33374] Setup wizard not properly offering the restart button

          I'm not entirely clear how to file a ticket to be on the radar for 2.0, so I hope I marked this right.

          Kohsuke Kawaguchi added a comment - I'm not entirely clear how to file a ticket to be on the radar for 2.0, so I hope I marked this right.

          R. Tyler Croy added a comment -

          kohsuke I usually assign stuff to danielbeck and hope for the best :-P

          R. Tyler Croy added a comment - kohsuke I usually assign stuff to danielbeck and hope for the best :-P

          Daniel Beck added a comment -

          Not a major issue as all qualifying plugins won't require a restart after JENKINS-33106 has been implemented.

          Daniel Beck added a comment - Not a major issue as all qualifying plugins won't require a restart after JENKINS-33106 has been implemented.

          Not targeted to 2.0 given that JENKINS-33106 is fixed and no recommended plugins require a restart

          Kohsuke Kawaguchi added a comment - Not targeted to 2.0 given that JENKINS-33106 is fixed and no recommended plugins require a restart

          Code changed in jenkins
          User: Keith Zantow
          Path:
          core/src/main/java/jenkins/install/SetupWizard.java
          core/src/main/resources/jenkins/install/pluginSetupWizard.properties
          war/src/main/js/api/pluginManager.js
          war/src/main/js/pluginSetupWizardGui.js
          war/src/main/js/templates/setupCompletePanel.hbs
          war/src/test/js/pluginSetupWizard-spec.js
          http://jenkins-ci.org/commit/jenkins/58ba65cacf743ed070ef0b63ea06521bef5e22d4
          Log:
          [FIX JENKINS-33374] - Correct Lifecycle-based restart behavior during setup wizard (#2515)

          • Add tests
          • One more test

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Keith Zantow Path: core/src/main/java/jenkins/install/SetupWizard.java core/src/main/resources/jenkins/install/pluginSetupWizard.properties war/src/main/js/api/pluginManager.js war/src/main/js/pluginSetupWizardGui.js war/src/main/js/templates/setupCompletePanel.hbs war/src/test/js/pluginSetupWizard-spec.js http://jenkins-ci.org/commit/jenkins/58ba65cacf743ed070ef0b63ea06521bef5e22d4 Log: [FIX JENKINS-33374] - Correct Lifecycle-based restart behavior during setup wizard (#2515) JENKINS-33374 - correct restart behavior during setup wizard Add tests One more test

          Oleg Nenashev added a comment -

          The fix has been merged towards jenkins-2.20

          Oleg Nenashev added a comment - The fix has been merged towards jenkins-2.20

            kzantow Keith Zantow
            kohsuke Kohsuke Kawaguchi
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: