Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33409

GitSCM.guessBrowser does not work if there are multiple refspecs

    XMLWordPrintable

Details

    Description

      This code fails to autodetect the GitHub browser (and thus hyperlink changelogs) when using github-branch-source, because there are two configs: one for origin branches, one for pull requests. They use the same URIs, so there is no reason it should not work.

      Attachments

        Issue Links

          links to

          Web Link PR 386

          Activity

            Ascending order - Click to sort in descending order
            recena Manuel Recena Soto added a comment -

            jglick What do you mean with "there are two configs"?

            recena Manuel Recena Soto added a comment - jglick What do you mean with " there are two configs "?
            jglick Jesse Glick added a comment -

            Here and here (using the same remote, note).

            jglick Jesse Glick added a comment - Here and here (using the same remote , note).
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/hudson/plugins/git/GitSCM.java
            src/test/java/hudson/plugins/git/browser/GithubWebTest.java
            http://jenkins-ci.org/commit/git-plugin/7efc2c1432b45cc6ad1333bf8d0e3357685a7d06
            Log:
            [FIXED JENKINS-33409] Incorrect repository browser detection when multiple refspecs were configured, even with the same URL.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/plugins/git/GitSCM.java src/test/java/hudson/plugins/git/browser/GithubWebTest.java http://jenkins-ci.org/commit/git-plugin/7efc2c1432b45cc6ad1333bf8d0e3357685a7d06 Log: [FIXED JENKINS-33409] Incorrect repository browser detection when multiple refspecs were configured, even with the same URL.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Mark Waite
            Path:
            src/main/java/hudson/plugins/git/GitSCM.java
            src/test/java/hudson/plugins/git/browser/GithubWebTest.java
            http://jenkins-ci.org/commit/git-plugin/0955025ba84f1c20adb965a4ba446537f5ee826b
            Log:
            Merge pull request #386 from jglick/GitSCM.guessBrowser-JENKINS-33409

            JENKINS-33409 Incorrect repository browser detection for github-branch-source

            Compare: https://github.com/jenkinsci/git-plugin/compare/fb68e5070c30...0955025ba84f

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: src/main/java/hudson/plugins/git/GitSCM.java src/test/java/hudson/plugins/git/browser/GithubWebTest.java http://jenkins-ci.org/commit/git-plugin/0955025ba84f1c20adb965a4ba446537f5ee826b Log: Merge pull request #386 from jglick/GitSCM.guessBrowser- JENKINS-33409 JENKINS-33409 Incorrect repository browser detection for github-branch-source Compare: https://github.com/jenkinsci/git-plugin/compare/fb68e5070c30...0955025ba84f
            markewaite Mark Waite added a comment -

            Included in git plugin 2.4.3, released 19 Mar 2016.

            markewaite Mark Waite added a comment - Included in git plugin 2.4.3, released 19 Mar 2016.

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: